openstack-qa-team team mailing list archive

[Dan Prince <dprince@xxxxxxxxxx>]

----- Original Message -----
> From: "David Kranz" <david.kranz@xxxxxxxxxx>
> To: "Daryl Walleck" <daryl.walleck@xxxxxxxxxxxxx>
> Cc: "<openstack-qa-team@xxxxxxxxxxxxxxxxxxx>" <openstack-qa-team@xxxxxxxxxxxxxxxxxxx>
> Sent: Thursday, May 31, 2012 4:43:58 PM
> Subject: Re: [Openstack-qa-team] deleted flavor failure
> 
> On 5/31/2012 4:28 PM, Daryl Walleck wrote:
> > This Nova review broke that test:
> > https://review.openstack.org/#/c/7735/
> > I haven't heard a final answer on how the Nova dev team wants to
> > handle this. I thought it was at least initially reverted.
> >
> > Daryl
> It seems that is not the case even though the bug tickets involved
> say
> fix committed.

We flip flopped on this issue. Initially a fix was committed to allow viewing deleted flavors. Then it was reverted. Then it was re-added (with a test case in Nova this last time!).

> But I think the tempest test is still wrong. Nova only
> needs to hold onto flavors until there are no instances that are
> built with it. 

Nova doesn't currently purge deleted flavor entries that are no longer used. This is currently something that a provider would need to implement as a backend SQL script which runs on a cron job or something and as such I'm not sure Tempest should actually test for this. If we add a Nova purge feature we might be able to test for this but it might involve a backend hook to ensure the purge has executed or something.

> Our test does not create any instances with the new flavor
> before deleting it. This is similar to the issue of cleaning up
> cached
> images on the compute nodes. Dan, do you have any comment about this?

I suppose you could spin up an instance, then delete the flavor, and then verify the existing instance is displayed correctly. My thought was that spinning up an instance was a bit on the expensive side... have at it if you want. Just don't make it a smoke test!

Dan


> 
>   -David
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> >
> > On May 31, 2012, at 3:10 PM, David Kranz wrote:
> >
> >> I am still seeing the below error with the latest versions of
> >> everything. Is this test passing for any of you? It seems to pass
> >> in jenkins so I don't know what the problem could be. Also, that
> >> code says:
> >>
> >>         # Delete the flavor
> >>         resp, _ =
> >>         self.admin_client.delete_flavor(self.new_flavor_id)
> >>         self.assertEqual(resp.status, 202)
> >>
> >> ???        # Deleted flavors can be seen via detailed GET
> >>         resp, flavor =
> >>         self.admin_client.get_flavor_details(self.new_flavor_id)
> >>         self.assertEqual(resp.status, 200)
> >>         self.assertEqual(flavor['name'], self.flavor_name)
> >>
> >>         # Deleted flavors should not show up in a list however
> >>         resp, flavors =
> >>         self.admin_client.list_flavors_with_detail()
> >>
> >> Is it really part of the spec that deleted flavors are never
> >> purged from the system?
> >>
> >>
> >>
> >>
> >>
> >> ======================================================================
> >> ERROR: Delete a flavor and ensure it is not listed
> >> ----------------------------------------------------------------------
> >> Traceback (most recent call last):
> >>   File
> >>   "C:\source\tempest\tempest\tests\compute\admin\test_flavors.py",
> >>   line 110, in test_get_flavor_details_for_deleted_flavor
> >>     resp, flavor =
> >>     self.admin_client.get_flavor_details(self.new_flavor_id)
> >>   File
> >>   "C:\source\tempest\tempest\services\nova\json\flavors_client.py",
> >>   line 39, in get_flavor_details
> >>     resp, body = self.get("flavors/%s" % str(flavor_id))
> >>   File "C:\source\tempest\tempest\common\rest_client.py", line
> >>   155, in get
> >>     return self.request('GET', url)
> >>   File "C:\source\tempest\tempest\common\rest_client.py", line
> >>   189, in request
> >>     raise exceptions.NotFound(resp_body)
> >> NotFound: Object not found
> >> Details: Object not found
> >> Details: {"itemNotFound": {"message": "The resource could not be
> >> found.", "code": 404}}
> >> -------------------->>  begin captured logging<<
> >>  --------------------
> >> tempest.common.rest_client: ERROR: Request URL:
> >> http://172.18.0.156:8774/v2/6b12f7a923c04f89bffb95bff997c3ef/flavors/1234
> >> tempest.common.rest_client: ERROR: Request Body: None
> >> tempest.common.rest_client: ERROR: Response Headers: {'date':
> >> 'Thu, 31 May 2012 19:57:42 GMT', 'status': '404',
> >> 'content-length': '78', 'content-type': 'application/json;
> >> charset=UTF-8', 'x-compute-request-id':
> >> 'req-b62a1f74-9919-4f8f-9d81-1006932894c9'}
> >> tempest.common.rest_client: ERROR: Response Body: {"itemNotFound":
> >> {"message": "The resource could not be found.", "code": 404}}
> >> --------------------->>  end captured logging<<
> >>  ---------------------
> >>
> >>
> >> --
> >> Mailing list: https://launchpad.net/~openstack-qa-team
> >> Post to     : openstack-qa-team@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~openstack-qa-team
> >> More help   : https://help.launchpad.net/ListHelp
> 
> 
> --
> Mailing list: https://launchpad.net/~openstack-qa-team
> Post to     : openstack-qa-team@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openstack-qa-team
> More help   : https://help.launchpad.net/ListHelp
>