openstack team mailing list archive
Mailing list archive
Re: Merge proposals and criteria for approval
On Tue, Dec 21, 2010 at 10:43 AM, Rick Clark <rick@xxxxxxxxxxxxx> wrote:
> I think that we should focus on finding regressions at review time not bugs.
> I propose that the following criteria be used for approving code reviews:
> * Architectural soundness
> * regression free
> * Code cleanliness (Pep8 compliance) and style
> * Complete test coverage
> * Documentation
> Any obvious non-regressing bugs should be filed in Launchpad at review
> time by the reviewer.
I kind of feel like accepting broken code just because it has good
documentation, test coverage or whatever is backwards.
But I don't know much about what's going on with nova development. It
might make sense to do this to get the change queue flushed.