← Back to team overview

openstack team mailing list archive

Re: [Branch ~hudson-openstack/nova/trunk] Rev 515: Fixes LP688545.


Hi, guys.

Can we please try to keep the commit messages more descriptive than this?

A changelog is a much more useful read if you can actually learn what
changed in the individual revisions. Referencing a bug number forces
people to go and look stuff up on the web and all they will (usually)
find is a description of the problem, not of the solution.

Apologies to Josh for singling him out. Other people are doing this too,
and people approving the merge proposal are also approving the commit
message, so it's something we need to pay more attention to.


Regards, Soren.

2011/1/4  <noreply@xxxxxxxxxxxxx>:
> Merge authors:
>  Josh Kearney (jk0)
> Related merge proposals:
>  https://code.launchpad.net/~jk0/nova/lp688545/+merge/45080
>  proposed by: Josh Kearney (jk0)
>  review: Approve - Vish Ishaya (vishvananda)
>  review: Approve - Todd Willey (xtoddx)
> ------------------------------------------------------------
> revno: 515 [merge]
> author: Josh Kearney <josh.kearney@xxxxxxxxxxxxx>
> committer: Tarmac
> branch nick: nova
> timestamp: Mon 2011-01-03 23:49:48 +0000
> message:
>  Fixes LP688545.
> modified:
>  nova/compute/manager.py
>  nova/db/sqlalchemy/__init__.py
>  nova/flags.py
>  nova/tests/test_xenapi.py
> --
> lp:nova
> https://code.launchpad.net/~hudson-openstack/nova/trunk
> You are subscribed to branch lp:nova.
> To unsubscribe from this branch go to https://code.launchpad.net/~hudson-openstack/nova/trunk/+edit-subscription
> [...]

Soren Hansen
Ubuntu Developer    http://www.ubuntu.com/
OpenStack Developer http://www.openstack.org/