openstack team mailing list archive

[Akira YOSHIYAMA <yosshy@xxxxxxxxxxxx>]

Hi Ken,

Thank you for your comments.

On Thu, 5 May 2011 09:54:00 -0700
Ken Pepple <ken.pepple@xxxxxxxxxxxxxx> wrote:

> On May 5, 2011, at 9:02 AM, Akira YOSHIYAMA wrote:
> > I uploaded my nova-cactus patches to:
> > 
> > 	http://www.debian.or.jp/~yosshy/nova-cactus-patches/
> > 
> > There are 4 categories of patches:
> > 
> > 1. DB modifications and changes for PostgreSQL
> > - Modified attach_time column in nova.db.sqlalchemy.models.Volume
> > - Added updater of volumes.attach_time.
> > - Modified the schema of instances.instance_type_id.
> > - Modified boolean updates and queries in nova.db.sqlalchemy.api.
> 
> Konnichiwa Yoshiyama-san:

Konnichiwa :-)

> Just going through the first batch of patches. Some have been fixed in trunk and others I have questions about:
> 
> 	- Modified attach_time column in nova.db.sqlalchemy.models.Volume
> 		This is destructive (although I'm not sure many sites will care). 

That's right.

> 		Can't we just alter the column ? Or does migrate not support that across DBs ?

I tried it with PostgreSQL but it didn't work. Also, attach_time
doesn't look used. So I gave up to alter it and made the migration
destructive. I didn't try with MySQL.

> 	- Modified the schema of instances.instance_type_id.
> 		I believe Dan Prince has patched this in trunk
>
> 	- Modified boolean updates and queries in nova.db.sqlalchemy.api.
> 		I believe I patched this in trunk (revno 1035) last week
> 

OK, I'll check them.

> 	- Added updater of volumes.attach_time
> 		Looks good
> 
> I'll keep going through the other patches when I get a second …

Thank you for your checking.

> Ken Pepple
> http://ken.pepple.info

Best regards,

  A. Yoshiyama <yosshy@xxxxxxxxxxxx>