← Back to team overview

openstack team mailing list archive

Re: Glance unit test failing on SID, bad state for Nova in SID

 

On 09/25/2011 08:42 PM, Vishvananda Ishaya wrote:
> It looks like you need to update python-novaclient to a newer version.
> 
> Nova depends on python-novaclient for some tests, but it is shipped separately.
> 
> Vish

Hi Vish,

Yes you are right, that was the issue. Thanks a lot, and sorry to have
missed that.

However, in this case, Nova *must* have a versionned (build)dependency
on python-novaclient! Can this be added upstream (maybe, by the new QA
team?), so that this is fixed? I will anyway, add it to my Debian
package before the upload.

Would it make sense to, in the future, have python-novaclient to be
included in nova itself, so that we can depend with python-novaclient
(=${binary:Version})? If not, I think we need a strategy so that such
important dependency isn't forgotten next time.

Also, what is the reason so that the unit test suite is having || true,
thus silently building a package even with such quite serious issue?

I still have one failed test:

======================================================================
ERROR: test_spawn_with_network_info
(nova.tests.test_libvirt.LibvirtConnTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/root/sources/diablo/nova/nova-2011.3/nova/tests/test_libvirt.py", line
887, in test_spawn_with_network_info
    network_info = _fake_network_info(self.stubs, 1)
NameError: global name '_fake_network_info' is not defined

----------------------------------------------------------------------

Was there some Ubuntu specific patches added in libvirt 0.9.2-4ubuntu13?

Thomas


Follow ups

References