← Back to team overview

openstack team mailing list archive

Re: [RFC] Stable branch

 

On Thu, 2011-10-13 at 09:16 -0400, James E. Blair wrote:
> Chris Wright <chrisw@xxxxxxxxxxxx> writes:
> 
> > * Mark McLoughlin (markmc@xxxxxxxxxx) wrote:
> >> On Wed, 2011-10-12 at 13:58 -0400, James E. Blair wrote:
> >> > Mark McLoughlin <markmc@xxxxxxxxxx> writes:
> >> > > Anyone can propose a cherry-pick to the maintainers. This helps ensure
> >> > > that the maintainers don't miss anything. To catch the maintainers
> >> > > attention, simply add
> >> > >
> >> > >  Cc: stable@xxxxxxxxxxxxx
> >> > 
> >> > Are you planning on grepping commit logs for that, or are you asking
> >> > people to email that address?
> >> 
> >> Yeah, it's just a marker to grep for.
> >> 
> >> Having a stable@xxxxxxxxxxxxx alias might be no harm, though.
> >
> > It's been invaluable for the kernel.  Having the marker in the commit
> > log allows for automated propagation.  When the commit hits upstream,
> > email lands in the stable inbox.  Not having the mail alias isn't as big
> > a deal as not having the marker in the commit log, though.
> 
> We can use gerrit to help with this.  Anyone can set up a watch in
> gerrit that notifies them of changes matching certain criteria.  To
> implement the above suggestion, you would create a watch on this screen:
> 
>   https://review-dev.openstack.org/#settings,projects
> 
> with the settings:
> 
>   Project Name: All-Projects
>        Only If: message:"stable@xxxxxxxxxxxxx"
> 
> And then check the "Email Notifications - New Changes" checkbox.  That
> will cause gerrit to send an email whenever a matching change is
> proposed, and better yet, the change shows up in your 'watched changes'
> list in gerrit.
> 
> The search language is very flexible, here's the whole vocabulary:
> 
>   https://review.openstack.org/Documentation/user-search.html

Wow, that's a nice tip. Thanks James.

> Of course the search string could be anything.  If we use gerrit project
> watches for this, I think we should not use an email address as the
> marker if it isn't a real email address.  Since if we use watches, we
> don't have to create a new mailing list, I'd prefer not to.  Maybe just
> search for the string "stable-updates".  On the other hand, if the
> maintainers want a list anyway, then we can turn on the mailing list
> feature for the group in launchpad, and use that address as the tag.

Yeah, having a mailing list or alias isn't critical.

Cheers,
Mark.



References