← Back to team overview

openstack team mailing list archive

Re: [RFC] Common config options module

 

Overall, I think it's a great thing to have commonality between the projects on option names and environment variables. I think it's worthwhile to push for that in the swift cli tool in the essex timeframe.

On the topic of common config libraries, though, I think the differences are less important. Mark's wiki page describing a common config library sounds interesting, but I agree with Monty that it may be better to be a separate (ie non-openstack) module.

--John


On Dec 5, 2011, at 3:36 PM, Vishvananda Ishaya wrote:

> Just read through the description and the code.  I don't have any issues with the way it is implemented, although others may have some suggestions/tweaks.  I think it is most important to get the common code established, so I'm up for implementing you changes in Nova.  I think it is important to get buy in from Jay and the Glance team ASAP as well.
> 
> It would also be great if the Swift team could do a quick review and at least give us a heads up on whether there are any blockers to moving to this "eventually".  They have a huge install base, so changing their config files could be significantly more difficult, but it doesn't look too diffferent from what they are doing.  John, thoughts?
> 
> Vish
> 
> On Nov 28, 2011, at 7:09 AM, Mark McLoughlin wrote:
> 
>> Hey,
>> 
>> I've just posted this blueprint:
>> 
>> https://blueprints.launchpad.net/openstack-common/+spec/common-config
>> http://wiki.openstack.org/CommonConfigModule
>> 
>> The idea is to unify option handling across projects with this new API.
>> The module would eventually (soon?) live in openstack-common.
>> 
>> Code and unit tests here:
>> 
>> https://github.com/markmc/nova/blob/common-config/nova/common/cfg.py
>> https://github.com/markmc/nova/blob/common-config/nova/tests/test_cfg.py
>> 
>> And patches to make both Glance and Nova use it are on the
>> 'common-config' branches of my github forks:
>> 
>> https://github.com/markmc/nova/commits/common-config
>> https://github.com/markmc/glance/commits/common-config
>> 
>> Glance and (especially) Nova still need a bunch of work to be fully
>> switched over to the new model, but both trees do actually appear to
>> work fine and could be merged now.
>> 
>> Lots of detail in there, but all comments are welcome :)
>> 
>> Thanks,
>> Mark.
>> 
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~openstack
>> Post to     : openstack@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~openstack
>> More help   : https://help.launchpad.net/ListHelp
> 

Attachment: smime.p7s
Description: S/MIME cryptographic signature


Follow ups

References