openstack team mailing list archive

[Vishvananda Ishaya <vishvananda@xxxxxxxxx>]

looks like an accidental omission to me.

Vish

On Jan 10, 2012, at 3:01 PM, Ewan Mellor wrote:

> In nova-manage, we have a ‘network modify’ command that takes --network but ‘network delete’ takes --fixed_range.  The flag was renamed (some while ago) for the ‘network delete’ case.  Was it intentional to leave the ‘network modify’ case alone?  That appears inconsistent.
>  
> Thanks,
>  
> Ewan.
>  
>  
>     @args('--fixed_range', dest="fixed_range", metavar='<x.x.x.x/yy>',
>             help='Network to delete')
> …
>     def delete(self, fixed_range=None, uuid=None):
>  
>  
>     @args('--network', dest="fixed_range", metavar='<x.x.x.x/yy>',
>             help='Network to modify')
> …
>     def modify(self, fixed_range, project=None, host=None,
>                dis_project=None, dis_host=None):
>  
>  
>  
> commit c32258c77d365534ac7b70bccbadb60a6ea4be1e
> Author: Brad Hall <brad@xxxxxxxxxx>
> Date:   Sun Oct 2 08:20:50 2011 -0700
>  
>     Change network delete to delete by uuid or cidr
>  
>     With melange it will be possible to have overlapping cidrs so it would be
>     better to specify the uuid of the network to delete.
>  
>     Change-Id: I6781225d587952cbab3387cd40164d8ac77c58d6
> _______________________________________________
> Mailing list: https://launchpad.net/~openstack
> Post to     : openstack@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openstack
> More help   : https://help.launchpad.net/ListHelp