openstack team mailing list archive

[Sandy Walsh <sandy.walsh@xxxxxxxxxxxxx>]

Seems kind of arbitrary doesn't it?

Perhaps something about not using decorators with arguments instead? (since they're the biggest wart on the ass of Python)

-S

________________________________
From: openstack-bounces+sandy.walsh=rackspace.com@xxxxxxxxxxxxxxxxxxx [openstack-bounces+sandy.walsh=rackspace.com@xxxxxxxxxxxxxxxxxxx] on behalf of Lorin Hochstein [lorin@xxxxxxxxxxxxxxxxxx]
Sent: Tuesday, January 17, 2012 12:09 PM
To: openstack@xxxxxxxxxxxxxxxxxxx
Subject: [Openstack] Proposal to limit decorator usage

While going through merge proposal, I ran across this one from Mark Washenberger about limiting the number of decorators to 2 in nova code: <https://review.openstack.org/2966>

There's some good discussion on this in the proposal comments, but I thought it should hit the mailing list as well, in case folks wanted to weigh in but hadn't seen the proposal (I don't have a strong opinion pro or con here).

Here's the proposed addition for HACKING:

Decorators
----------
A function or method should not have more than two decorators applied to it
where it is defined.

Decorators are a powerful feature of Python that can eliminate some repetitive
code. However, decorator usage can be more difficult to debug or maintain than
alternative approaches to reduce repetition. These difficulties multiply when
decorators are stacked on top of each other. To ensure judicious use, we
therefore limit decorator depth to no more than two.



Take care,

Lorin
--
Lorin Hochstein
Lead Architect - Cloud Services
Nimbis Services, Inc.
www.nimbisservices.com<https://www.nimbisservices.com/>