← Back to team overview

openstack team mailing list archive

Re: Libvirt File Injection

 

On Mon, Jan 30, 2012 at 1:05 PM, Brian Waldon <brian.waldon@xxxxxxxxxxxxx>wrote:

> After implementing a working version of file injection on Libvirt, a good
> question was brought up on the merge prop: how should we handle a file
> injection failure? Injection could fail for several reasons: missing
> necessary libraries, unsupported image formats and bad permissions are just
> a few. There seem to be two clear paths forward:
>
> 1) Log an error, set the instance to ERROR, add an asynchronous fault to
> the instance in the db
> 2) Log a warning, move on with the boot process
>


My preference would be to log a warning and move on with the boot process
(#2). Or perhaps we could address this with some sort of async error
messages concept?

Also, Armando just file this ticket to change how XenServer currently
handles admin password failures:

 https://bugs.launchpad.net/nova/+bug/923865

I understand file injection is slightly different than admin passwords but
it would seem the preference is to treat these types of failures as
warnings and not errors.



> It's not obvious which of these is the best route to take from a user's
> point of view. I'm currently leaning towards option 1 as I wouldn't want to
> have an instance come up (and be billed for it) while it wasn't what I
> explicitly requested.
>
> I would love to get some help with this problem. You can either reply
> directly to this email, or head over to the merge prop:
> https://review.openstack.org/#change,3526
>
>
> Brian Waldon
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openstack
> Post to     : openstack@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openstack
> More help   : https://help.launchpad.net/ListHelp
>
>


-- 
Dan Prince
princepd@xxxxxxxxxxxxxx

Follow ups

References