openstack team mailing list archive

[Devdeep Singh <devdeep.singh@xxxxxxxxxx>]

Hi,

Can someone have a look at the changes and approve them if they look fine https://review.openstack.org/#change,3343?
 
Regards,
Devdeep

-----Original Message-----
From: openstack-bounces+devdeep.singh=citrix.com@xxxxxxxxxxxxxxxxxxx [mailto:openstack-bounces+devdeep.singh=citrix.com@xxxxxxxxxxxxxxxxxxx] On Behalf Of Devdeep Singh
Sent: Wednesday, February 01, 2012 8:14 PM
To: Chris Behrens; Vishvananda Ishaya
Cc: openstack@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Openstack] Fast cloning - FF-Exception request

Hi,

I have updated the fast cloning changes with an new patch set. Caching is off by default for xenapi and the default behavior doesn't change (for libvirt or xenapi).  It also addresses the other review comments that were given for the feature.

Regards,
Devdeep

-----Original Message-----
From: Chris Behrens [mailto:chris.behrens@xxxxxxxxxxxxx] 
Sent: Wednesday, February 01, 2012 1:25 AM
To: Vishvananda Ishaya
Cc: Chris Behrens; Devdeep Singh; openstack@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Openstack] Fast cloning - FF-Exception request

I just chatted with Paul.

We're okay with this if we can have a flag to allow turning off the caching part of things, since both cow and caching are behavior changes for the Xen side.  There's already a flag for 'cow', so that's covered, but there is not one for caching in the current branch up for review.  I understand that they should default to 'on' to match libvirt functionality, but I think we need to have a way to have Xen operate how it did before since it has been stable.  I'm definitely looking forward to these features, but would like to minimize the impact in case it is unstable or people simply want the current behavior.

(I posted the same comments on the review)

- Chris


On Jan 31, 2012, at 11:02 AM, Vishvananda Ishaya wrote:

> I'm ok with this going in, but I would like to leave it up to the guys who are using Xen on a daily basis.  So if Chris Behrens and Paul Voccio are ok with it, I think an FFE is fine.
> 
> Vish
> 
> On Jan 31, 2012, at 10:31 AM, Devdeep Singh wrote:
> 
>> Hi,
>>  
>> I am asking for a Feature-Freeze exception for the blueprinthttps://blueprints.launchpad.net/nova/+spec/fast-cloning-for-xenserver.
>>  
>> I appreciate that it is now late for getting this feature in, however we are ready to get this feature early in E4.
>>  
>> We have got a few reviews in the queue, and we are close to completing them. It is my understanding that E4 was not for big changes. However, this change only touches the xenapi code for instance creation. I have tested these change extensively to make sure it doesn't break anything. Moreover, it will help close the gap between KVM and XenAPI.
>>  
>> Thanks,
>> Devdeep
>> _______________________________________________
>> Mailing list: https://launchpad.net/~openstack
>> Post to     : openstack@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~openstack
>> More help   : https://help.launchpad.net/ListHelp
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~openstack
> Post to     : openstack@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openstack
> More help   : https://help.launchpad.net/ListHelp


_______________________________________________
Mailing list: https://launchpad.net/~openstack
Post to     : openstack@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp