openstack team mailing list archive

[Joshua Harlow <harlowja@xxxxxxxxxxxxx>]

Does anyone else feel that the following seems really "dirty", or is it just me.

"adding a few sleep(0) calls in various places in the
Nova codebase (as was recently added in the _sync_power_states()
periodic task) is an easy and simple win with pretty much no ill
side-effects. :)"

Dirty in that it feels like there is something wrong from a design point of view.
Sprinkling "sleep(0)" seems like its a band-aid on a larger problem imho.
But that's just my gut feeling.

:-(

On 3/2/12 8:26 AM, "Armando Migliaccio" <Armando.Migliaccio@xxxxxxxxxxxxx> wrote:

I knew you'd say that :P

There you go: https://bugs.launchpad.net/nova/+bug/944145

Cheers,
Armando

> -----Original Message-----
> From: Jay Pipes [mailto:jaypipes@xxxxxxxxx]
> Sent: 02 March 2012 16:22
> To: Armando Migliaccio
> Cc: openstack@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Openstack] eventlet weirdness
>
> On 03/02/2012 10:52 AM, Armando Migliaccio wrote:
> > I'd be cautious to say that no ill side-effects were introduced. I found a
> race condition right in the middle of sync_power_states, which I assume was
> exposed by "breaking" the task deliberately.
>
> Such a party-pooper! ;)
>
> Got a link to the bug report for me?
>
> Thanks!
> -jay

_______________________________________________
Mailing list: https://launchpad.net/~openstack
Post to     : openstack@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp