← Back to team overview

openstack team mailing list archive

Re: Gerrit minimum review time frame



I actually thought this same thought just yesterday. There have been 2-3 times (in nova) when I was about to respond to an inline comment on one of my own branches, saved as a draft, and then bam, it was approved by a couple people and going in. 

I'd love for there to be an unconference at the summit if there continues to be disagreement on the subject.


-----Original Message-----
From: "Joe Gordon" <jogo@xxxxxxxxxxxxxxxx>
Sent: Monday, March 12, 2012 5:59pm
To: openstack@xxxxxxxxxxxxxxxxxxx
Subject: [Openstack] Gerrit minimum review time frame

Mailing list: https://launchpad.net/~openstack
Post to     : openstack@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp
Hi All,

I have noticed that some Gerrit branches get approved very quickly,
sometimes in a matter of minutes.   While most of the time these branches
are vetted properly, the window for reviewing can be so small that a
non-trivial branch lands but without enough vetting.  If someone is in a
meeting for half on hour they may miss the entire review window.  To fix
this problem I propose a minimum time frame (should be overridable in an
emergency) for a branch to be approved, perhaps 2 hours.  This time frame
would start on 'Upload time.'

Joe Gordon