openstack team mailing list archive

[Thompson Lee <stagr.lee@xxxxxxxxx>]

On Apr 24, 2012, at 9:28 AM, Ghe Rivero wrote:

> 
> 
> On Tue, Apr 24, 2012 at 2:40 PM, Mark McLoughlin <markmc@xxxxxxxxxx> wrote:
> Hi Ghe,
> 
> On Tue, 2012-04-24 at 12:15 +0200, Ghe Rivero wrote:
> > Hi Everyone,
> >    i've been looking through wsgi code, and i have found a lot of
> > duplicated code between all the projects.
> 
> Thanks for looking into this. It sounds quite daunting.
> 
> I wonder could we do this iteratively by extract the code which is most
> common into openstack-common, move the projects over to that and then
> start again on the next layer?
> 
> Cheers,
> Mark.
> 
> I have plans to try to move as much as possible into openstack-common. I will start with nova as a test bed and see what we get from there. My future plans include db code and tests (in the case of quantum, plugins test also have a lot of duplicated code).
> I register a bp for the wsgi issue: https://blueprints.launchpad.net/openstack-common/+spec/wsgi-common
> 
> Ghe Rivero

Is there a code metrics site that continually reports on metrics like duplication?  Adding Ghe's report to a metric site would be the first step.  That has always been a starting point as it gives code reviewers quick evaluation criteria to stop duplication before it ends up in trunk.  Going at it directly fixes it looking backward but the duplication ends up back int the code eventually.  The reports help fix the issue going forward.