openstack team mailing list archive

["Patel, Nayna (Cloud Services)" <nayna.patel@xxxxxx>]

+1

From: openstack-bounces+nayna.patel=hp.com@xxxxxxxxxxxxxxxxxxx [mailto:openstack-bounces+nayna.patel=hp.com@xxxxxxxxxxxxxxxxxxx] On Behalf Of Dan Wendlandt
Sent: Tuesday, April 24, 2012 2:58 PM
To: Joe Gordon
Cc: openstack@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Openstack] [OpenStack][Nova] Minimum required code coverage per file


On Tue, Apr 24, 2012 at 1:11 PM, Joe Gordon <jogo@xxxxxxxxxxxxxxxx<mailto:jogo@xxxxxxxxxxxxxxxx>> wrote:
Hi All,

I would like to propose a minimum required code coverage level per file in Nova.  Say 80%.  This would mean that any new feature/file should only be accepted if it has over 80% code coverage.  Exceptions to this rule would be allowed for code that is covered by skipped tests (as long as 80% is reached when the tests are not skipped).

With 193 python files in nova/tests, Nova unit tests produce 85% overall code coverage (calculated with ./run_test.sh -c [1]).  But 23% of files (125 files) have lower then 80% code coverage (30 tests skipped on my machine).  Getting all files to hit the 80% code coverage mark should be one of the goals for Folsom.


Thanks for driving this Joe.

Some files with low coverage:



nova/network/quantum/client  36%

nova/network/quantum/melange_connection  38%

These two files will be removed in Folsom, as Nova will use the proper Quantum client lib, instead of having its own copy.  Melange client functionality will be folded into Quantum client.

Dan



best,
Joe Gordon



[1] With https://review.openstack.org/#/c/6750/
_______________________________________________
Mailing list: https://launchpad.net/~openstack
Post to     : openstack@xxxxxxxxxxxxxxxxxxx<mailto:openstack@xxxxxxxxxxxxxxxxxxx>
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp



--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira, Inc: www.nicira.com<http://www.nicira.com>
twitter: danwendlandt
~~~~~~~~~~~~~~~~~~~~~~~~~~~