← Back to team overview

openstack team mailing list archive

Re: database migration cleanup

 


----- Original Message -----
> From: "Johannes Erdfelt" <johannes@xxxxxxxxxxx>
> To: openstack@xxxxxxxxxxxxxxxxxxx
> Sent: Friday, April 27, 2012 10:20:38 AM
> Subject: Re: [Openstack] database migration cleanup
> 
> On Thu, Apr 26, 2012, Dan Prince <dprince@xxxxxxxxxx> wrote:
> > The OpenStack Essex release had 82 database migrations. As these
> > grow
> > in number it seems reasonable to clean house from time to time. Now
> > seems as good a time as any.
> 
> Mirations don't appear to be particularly slow right now, and it
> doesn't
> appear that merging migrations will make them significantly faster.
> 
> What exactly is the benefit of doing this?

Speed wasn't the primary motivation here I suppose. Do we really want to continue to maintain 100+ migrations in our codebase over the lifetime of the project? As we add more and more to our pep8/hacking tools this could become an annoying burden right? I mean why require end users to run migrations that add and drop the same table repeatedly?


> 
> By merging migrations, we lose history in git for why the migrations
> were added in the first place.

I'm not sure I understand? Git still has the source code for the old migrations. All you'd need to do is checkout an old version of master or look at the stable/essex, stable/diablo branches right?

> 
> JE
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~openstack
> Post to     : openstack@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openstack
> More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References