openstack team mailing list archive

[Sean Dague <sdague@xxxxxxxxxxxxxxxxxx>]

On 05/18/2012 02:14 PM, Jay Pipes wrote:
> On 05/17/2012 06:38 PM, Vishvananda Ishaya wrote:
> > On May 17, 2012, at 1:52 PM, Sean Dague wrote:
<snip>
> > So I guess this would be my strategy:
> >
> > a) remove get_connection from the drivers (and just have it construct
> > the 'connection' class directly)
> > b) modify the global get_connection to construct the drivers for
> > backwards compatibilty
> > c) modify the documentation to suggest changing drivers by specifying
> > the full path to the driver instead of connection_type
> > d) rename the connection classes to something reasonable representing
> > drivers (libvirt.driver:LibvirtDriver() vs
> > libvirt.connection.LibvirtConnection)
> > e) bonus points if it could be done with a short path for ease of use
> > (compute_driver=libvirt.LibvirtDriver vs
> > compute_driver=nova.virt.libvirt.driver.LibvirtDriver)

A review which covers a, b, and part of d is up at - 
https://review.openstack.org/#/c/7930/. I'd like to get comments on the 
work so far, and handle c, the rest of d, and e in a second round once a 
version of this lands.

Reviews appreciated.

	-Sean

--
Sean Dague
IBM Linux Technology Center
email: sdague@xxxxxxxxxxxxxxxxxx
alt-email: sldague@xxxxxxxxxx