openstack team mailing list archive

[iryoung jeong <iryoung@xxxxxxxxx>]

Hello,

Actually, I've been making them to pass functests, and I don't know exactly
where to send mail, and I thought it wouldn't take much time.
So I'd just keep focusing on making the code , and I thought, after
finishing the job, I'll send to you or community about the result.
(but, there're much more jobs to do than I expected, I'm doing this as my
hobby project now, so It's few more days then I thought. :(

Anyway, current status is that I make your PatchSet 3 passed all
unit/functests with webob 1.1 and only 4 tests failed with webob 1.2b3.
After I compared my patch & your patchsets, I thought they looks similar,
therefore I rebased my patch based on PatchSet 3 and keep trying to make
them pass functests.

After finishing them, would it better to push to 7569 or make another
review for bug888371? or sending a patch to someone?

- iryoung

On Mon, Jun 4, 2012 at 9:28 AM, Pete Zaitcev <zaitcev@xxxxxxxxxx> wrote:

> Hi,
>
> In a review on change 7569, you wrote:
>
> > Because I'm new to this project, I can't sure what should I do.
> > Shoud I just create new review of bug 888371 with my code or just
> > help this review to fix same issue?
>
> I asked to take this to e-mail, but never heard back. If you have
> any code that we could incorporate, if would be appreciated.
>
> In particular I'd love fixes for testFileListingLimitMarkerPrefix,
> which would work on both WebOb 1.0.8 and 1.2 betas. My patch set #4
> in change 7569 still does not have a viable fix for that one.
>
> I looked at Severin's patch, but there was nothing useful in it.
> I already fixed the problems that he addressed, but there is much
> more to it. Thanks for drawing my attention to the bug 888371, however.
> I did not notice it before.
>
> -- Pete
>