openstack team mailing list archive

["Dugger, Donald D" <donald.d.dugger@xxxxxxxxx>]

I have to agree with Daniel on this one.  I frequently work on issues where multiple people contribute to the code in a patch and therefore you wind up with multiple Signed-off-by's.  Yes, it's a little redundant when it's exclusively your code but you need these tags when there are multiple contributors and if you don't provide the tag then you don't know if the code came exclusively from the submitter or if the Signed-off tag was left off by mistake.

--
Don Dugger
"Censeo Toto nos in Kansa esse decisse." - D. Gale
Ph: 303/443-3786


-----Original Message-----
From: openstack-bounces+donald.d.dugger=intel.com@xxxxxxxxxxxxxxxxxxx [mailto:openstack-bounces+donald.d.dugger=intel.com@xxxxxxxxxxxxxxxxxxx] On Behalf Of Johannes Erdfelt
Sent: Thursday, June 28, 2012 10:21 AM
To: openstack@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Openstack] RFC: Thoughts on improving OpenStack GIT commit practice/history

First off, I wanted to say I think these are a great set of
recommendations.

On Wed, Jun 27, 2012, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote:
>     Fixes: bug #1003373
>     Implements: blueprint libvirt-xml-cpu-model
>     Change-Id: I4946a16d27f712ae2adf8441ce78e6c0bb0bb657
>     Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
>
> As well as the 'Signed-off-by' tag, there are various other ad-hoc
> tags that can be used to credit other people involved in a patch
> who aren't the author.

What is the Signed-off-by tag used for?

Your examples have yourself, but isn't that kind of implied by
submitting the patch for review in the first place?

JE


_______________________________________________
Mailing list: https://launchpad.net/~openstack
Post to     : openstack@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp