openstack team mailing list archive
-
openstack team
-
Mailing list archive
-
Message #13958
Re: PEP8 checks
On 07/02/2012 06:46 AM, John Garbutt wrote:
> Hi,
>
> I noticed I can now run the pep8 tests like this (taken from Jenkins job):
> tox -v -epep8
> ...
> pep8: commands succeeded
> congratulations :)
>
> But the old way to run tests seems to fail:
> ./run-tests.sh -p
> ...
> File "/home/johngar/openstack/nova/.venv/local/lib/python2.7/site-packages/pep8.py", line 1220, in check_logical
> for result in self.run_check(check, argument_names):
> TypeError: 'NoneType' object is not iterable
>
> Is this expected?
> Did I just miss an email about this change?
It's not really expected, and I honestly don't understand why
run_tests.sh -p would have problems running pep8. Although we do not use
run_tests.sh for anything in jenkins, we have not done anything to
disable or change what it's doing.
I'm looking at it right now, lemme see what's up.
Monty
Follow ups
References