openstack team mailing list archive

[Leander Bessa Beernaert <leanderbb@xxxxxxxxx>]

I have never tested it on a machine which doesn't have libvirt, i'll get
back to you on that.

I've ran "tox -v -epy27" and it produced this ouput

> ----------------------------------------------------------------------
> Ran 0 tests in 0.001s
> OK
> _____________________________________________________________________________________________________
> summary
> _____________________________________________________________________________________________________
>   py27: commands succeeded
>   congratulations :)


and this is the output produced by "tox -v -efull":

----------------------------------------------------------------------
> Ran 3046 tests in 217.842s
> OK (SKIP=5)
> Exception KeyError: KeyError(25433840,) in <module 'threading' from
> '/usr/lib/python2.7/threading.pyc'> ignored
> _____________________________________________________________________________________________________
> summary
> _____________________________________________________________________________________________________
>   full: commands succeeded
>   congratulations :)


I think the problem still remains :S

On Mon, Jul 2, 2012 at 4:48 PM, Monty Taylor <mordred@xxxxxxxxxxxx> wrote:

> Run:
>
>   sudo pip install tox
>
> And you will get the tox command.
>
> Does ./run_tests.sh -N nova.tests.test_libvirt work fine when you
> _don't_ have libvirt? It needs to skip the test if you don't have
> libvirt installed, and it needs to run it and pass if you do.
>
> Jenkins is going to run "tox -v -epy27" and then eventually also "tox -v
> -efull" - so make sure both of those work and you'll be set.
>
> Monty
>
> On 07/02/2012 10:30 AM, Leander Bessa Beernaert wrote:
> > Running with " ./run_tests.sh -N nova.tests.test_libvirt" works just
> > fine, however i don't know if this is enough to get it past jenkins :/
> >
> > On Mon, Jul 2, 2012 at 3:26 PM, Daniel P. Berrange <berrange@xxxxxxxxxx
> > <mailto:berrange@xxxxxxxxxx>> wrote:
> >
> >     On Mon, Jul 02, 2012 at 01:43:31PM +0100, Leander Bessa Beernaert
> wrote:
> >     > So, if no system packages can be imported, how do you test the
> >     "connection"
> >     > class for the libvirt driver?
> >     >
> >     > How does that particular test case wrap around the fact that it
> >     requires
> >     > the libvirt module? The only thing i could find are these lines of
> >     code in
> >     > the driver's __init__ method. Do these somehow detect if this is a
> >     unit
> >     > test environment and import the fakelibvirt driver instead? I'm no
> >     expert
> >     > in python so i'm not sure what's happening there :s
> >     >
> >     > > global libvirt
> >     > > if libvirt is None:
> >     > >     libvirt = __import__('libvirt')
> >
> >     If you have installed all the neccessary python packages on your
> >     local host, then it is entirely possible to run the Nova test
> >     suites without using virtualenv. You just need to pass the '-N'
> >     arg to the run_tests.sh script, eg on my Fedora 17 host, I can
> >     run
> >
> >        ./run_tests.sh -N nova.tests.test_libvirt
> >
> >     Regards,
> >     Daniel
> >     --
> >     |: http://berrange.com      -o-
> >      http://www.flickr.com/photos/dberrange/ :|
> >     |: http://libvirt.org              -o-
> >     http://virt-manager.org :|
> >     |: http://autobuild.org       -o-
> >     http://search.cpan.org/~danberr/ :|
> >     |: http://entangle-photo.org       -o-
> >     http://live.gnome.org/gtk-vnc :|
> >
> >
>
>