openstack team mailing list archive

[Doug Hellmann <doug.hellmann@xxxxxxxxxxxxx>]

On Mon, Jul 9, 2012 at 9:16 PM, Dan Prince <dprince@xxxxxxxxxx> wrote:

>
>
> ----- Original Message -----
> > From: "Dave Walker" <DaveWalker@xxxxxxxxxx>
> > To: "Monty Taylor" <mordred@xxxxxxxxxxxx>
> > Cc: openstack@xxxxxxxxxxxxxxxxxxx, "John Garbutt" <
> John.Garbutt@xxxxxxxxxx>
> > Sent: Monday, July 9, 2012 6:01:19 PM
> > Subject: Re: [Openstack] PEP8 checks
> >
> > On Mon, Jul 02, 2012 at 08:28:04AM -0400, Monty Taylor wrote:
> > >
> > >
> > > On 07/02/2012 06:46 AM, John Garbutt wrote:
> > > > Hi,
> > > >
> > > > I noticed I can now run the pep8 tests like this (taken from
> > > > Jenkins job):
> > > >   tox -v -epep8
> > > >   ...
> > > >   pep8: commands succeeded
> > > >   congratulations :)
> > > >
> > > > But the old way to run tests seems to fail:
> > > >   ./run-tests.sh -p
> > > >   ...
> > > >   File
> > > >
> "/home/johngar/openstack/nova/.venv/local/lib/python2.7/site-packages/pep8.py",
> > > >   line 1220, in check_logical
> > > >       for result in self.run_check(check, argument_names):
> > > >   TypeError: 'NoneType' object is not iterable
> > > >
> > > > Is this expected?
> > > > Did I just miss an email about this change?
> > >
> > > I cannot reproduce this on my system. Can you run
> > > "bash -x run_tests.sh -p" and pastebin the output? Also,
> > > tools/with_venv.sh pep8 --version just to be sure.
> > >
> >
> > Hi,
> >
> > The issue is that as of a recent change to upstream pep8 [1], the
> > additional pep8 rules in tools/hacking.py need to be changed from
> > returns to yields.. :(
>
> This brings up a good point. Why are we following the latest pep8 release
> so closely in Nova? The latest release is hardly a month old and we are
> already using it? We aren't necessarily doing the same for all the other
> OpenStack projects... (nor am I suggesting that we do). So why Nova?
>
> I'm not convinced the latest pep8 "features" really provide us enough
> benefit that we need to bump our pep8 baseline every month or two.  in fact
> they may be hurting us in terms of churn, extra work, back-portability of
> upstream patches, etc. Ultimately is tracking the latest pep8 really worth
> it?
>

+1

Some of the "features" are requiring useless whitespace changes to working
code just to get through the gating tests. In ceilometer we've pegged our
pep8 tests to 1.1.

Doug


>
>
> >
> > [1]
> >
> https://github.com/jcrocholl/pep8/commit/b9f72b16011aac981ce9e3a47fd0ffb1d3d2e085
> >
> > Kind Regards,
> >
> > Dave Walker <Dave.Walker@xxxxxxxxxxxxx>
> > Engineering Manager,
> > Ubuntu Server Infrastructure
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~openstack
> > Post to     : openstack@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~openstack
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openstack
> Post to     : openstack@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openstack
> More help   : https://help.launchpad.net/ListHelp
>