openstack team mailing list archive

[Jay Pipes <jaypipes@xxxxxxxxx>]

On 07/10/2012 01:52 PM, Eric Windisch wrote:
> I've had code reviews sitting out for over a week, looking to fix issues with the ZeroMQ driver in openstack-common. I'd love to get it fixed, and nudged a couple of people to get the reviews in, but figured that it would get in eventually - and if not, I'd prod harder, or perhaps someone else that would want to see these problems fixed, would help review.  Instead... 

Sorry, all you had to do was send a note out to the ML (like this one)
asking for reviews...

> Today, I had someone ignore my reviews in progress, push his own review, and even APPROVED his own review.
> 
> What the hell?

Yes, this is not good. Jason, I understand you were just trying to fix
Jenkins jobs, but you need to be cognizant of others...

Best chalked up to a learning experience guys,
-jay

> Review in question:
> https://review.openstack.org/#/c/9594/
> (My) Reviews in progress:
> https://review.openstack.org/#/q/status:open+project:openstack/openstack-common+branch:master+topic:bug/1021459,n,z
>