← Back to team overview

openstack team mailing list archive

Re: Don't bypass code-review.

 

Slap on wrist bad person who did that, badness++

'Those responsible have been sacked'???

-Josh

On 7/10/12 10:52 AM, "Eric Windisch" <eric@xxxxxxxxxxxxxxxx> wrote:

I've had code reviews sitting out for over a week, looking to fix issues with the ZeroMQ driver in openstack-common. I'd love to get it fixed, and nudged a couple of people to get the reviews in, but figured that it would get in eventually - and if not, I'd prod harder, or perhaps someone else that would want to see these problems fixed, would help review.  Instead...

Today, I had someone ignore my reviews in progress, push his own review, and even APPROVED his own review.

What the hell?

Review in question:
https://review.openstack.org/#/c/9594/
(My) Reviews in progress:
https://review.openstack.org/#/q/status:open+project:openstack/openstack-common+branch:master+topic:bug/1021459,n,z

--
Eric Windisch

_______________________________________________
Mailing list: https://launchpad.net/~openstack
Post to     : openstack@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp


References