openstack team mailing list archive
-
openstack team
-
Mailing list archive
-
Message #18596
Re: Getting approved to submit code for review for OpenStack Swift
Thanks Clay,
I don't have a big set of changes, they are minor tweaks really. Hopefully
the code changes will be simply enough to review without engaging in a more
involved discussion ahead of time.
You can find them talked about at:
Unnecessary <https://answers.launchpad.net/swift/+question/213796> fetch of
metadata in DELETE's mkstemp context?
<https://answers.launchpad.net/swift/+question/213796>
wishlist: Enhance <https://bugs.launchpad.net/swift/+bug/1067108> internal
server-to-server logs to add referer and a user-agent
<https://bugs.launchpad.net/swift/+bug/1067108>
I looked folks up on openstack-dev, and one person said it takes a number of
hours for gerrit and launchpad to sync up. So I will try again tomorrow.
Thanks for the welcome,
-peter
From: Clay Gerrard <clay.gerrard@xxxxxxxxx>
Date: Wednesday, November 14, 2012 8:33 PM
To: Peter Portante <peter.a.portante@xxxxxxxxx>,
"openstack@xxxxxxxxxxxxxxxxxxx" <openstack@xxxxxxxxxxxxxxxxxxx>
Subject: Re: Getting approved to submit code for review for OpenStack Swift
Hi Peter,
No, nothing special should be needed - sometimes it's tricky to get your
launchpad account hooked into to review.openstack.org
<http://review.openstack.org> - but if that's giving you trouble just ask
for help in #openstack-dev (we've all been there).
So yeah, if you've got some code that helps fix a problem or is small
improvement that works for you - just push it on up - we'd love to take a
look at it! We'll give you feedback if you have any questions.
http://wiki.openstack.org/GerritWorkflow should be mostly all you need.
OTOH, if you have a bigger idea for something new or different, it makes the
review process easier if you can talk a little bit about what you're doing
with some of the swift core devs - context really helps on something big or
new - plus if you can explain what you're thinking before you get too far
down in the weeds, sometimes they can warn you about any big gotchas that
may not be obvious at first but could complicate the implementation just
cause of some weird corner of the swift internals. Technically I think
there's also like a blueprint "process"
(http://wiki.openstack.org/Blueprints ?), but I'm not sure it's strictly
necessary. But it'd be more paperwork for notmyname - so that's fun.
Either way, we'd love to hear about what you're doing with swift, you can
post back here on the openstack mailing list, or even better - easiest place
to find some swifters is in #openstack-swift on Freenode!
Welcome!
-clayg
On Wed, Nov 14, 2012 at 12:48 PM, Peter Portante
<peter.a.portante@xxxxxxxxx> wrote:
> Good afternoon,
>
> I was wondering if there is anything else I must do in order to get
> approved to submit code for review in Gerrit for OpenStack Swift.
>
> Thanks,
>
> -peter
> --
> This message was sent from Launchpad by
> Peter Portante (https://launchpad.net/~peter-a-portante)
> using the "Contact this team's admins" link on the OpenStack Contributors
> team page (https://launchpad.net/~openstack-cla).
> For more information see
> https://help.launchpad.net/YourAccount/ContactingPeople
References