← Back to team overview

oqgraph-dev team mailing list archive

Re: OQGraph crash with larger graphs

 

Hi Andrew,

After a bit more testing I found still one more minor issue. Query execution
still works fine now, but when shutting down mariadb I get a different crash
(see log attached). Let me know if you need more info.

Grs,
Heinz

On Monday 30 November 2015 13:32:49 Heinz Wiesinger wrote:
> Hi Andrew,
>
> Sorry for taking my time with this. You surprised me a bit with delivering a
> patch so quickly ;)
>
> It looks like your hunch is correct. After applying the patch my crashes are
> gone.
>
> Thanks for looking into this and I'm looking forward to seeing the pull
> request :)
>
> Grs,
> Heinz
>
> (Sorry Andrew for getting this twice. Forgot to include the list in the
> previous mail)
>
> On Monday 16 November 2015 23:11:18 you wrote:
> > Hi Heinz
> >
> > I'm going to take a punt and say that I missed this applying the fix for
> > MDEV-6282 in all cases
> >
> > If you can manually apply the following patch and see if it fixes your
> > problem?
> >
> > HTH
> > --Andrew
> >
> >
> >
> > diff --git a/storage/oqgraph/ha_oqgraph.cc b/storage/oqgraph/ha_oqgraph.cc
> > index 89bc912..b4cf03c 100644
> > --- a/storage/oqgraph/ha_oqgraph.cc
> > +++ b/storage/oqgraph/ha_oqgraph.cc
> > @@ -1099,6 +1099,10 @@ int ha_oqgraph::info(uint flag)
> >
> >  int ha_oqgraph::extra(enum ha_extra_function operation)
> >  {
> >
> > +  if (graph->get_thd() != current_thd) {
> > +    DBUG_PRINT( "oq-debug", ("rnd_pos g->table->in_use: 0x%lx <--
> > current_thd 0x%lx", (long) graph->get_thd(), (long) current_thd));
> > +    graph->set_thd(current_thd);
> > +  }
> >
> >    return edges->file->extra(operation);
> >
> >  }
> >
> > On 16/11/15 19:17, Heinz Wiesinger wrote:
> > > Hey everyone,
> > >
> > > We've been playing around a bit more with OQGraphv3 and when trying to
> > > put
> > > it on one of our production setups we found it crashing in situations
> > > that didn't happen on our testing setup. After a bit of back and forth I
> > > managed to reproduce it pretty reliable and added info to
> > > https://mariadb.atlassian.net/browse/MDEV-8206
> > >
> > > From what I see it seems that the crash only happens when the graph is
> > > above a certain size. But with our code, we'd hit that limit pretty
> > > easily.
> > >
> > > Could someone maybe take a look at that please? :)
> > >
> > > Grs,
> > > Heinz
mysqld: /usr/src/sbo_tmp/mariadb-10.0.22/sql/handler.cc:2473: THD* handler::ha_thd() const: Assertion `!table || !table->in_use || table->in_use == _current_thd()' failed.
151130 14:03:56 [ERROR] mysqld got signal 6 ;
This could be because you hit a bug. It is also possible that this binary
or one of the libraries it was linked against is corrupt, improperly built,
or misconfigured. This error can also be caused by malfunctioning hardware.

To report this bug, see http://kb.askmonty.org/en/reporting-bugs

We will try our best to scrape up some info that will hopefully help
diagnose the problem, but since we have already crashed,
something is definitely wrong and this may fail.

Server version: 10.0.22-MariaDB-debug
key_buffer_size4217728
read_buffer_size1072
max_used_connections=5
max_threads3
thread_count=0
It is possible that mysqld could use up to
key_buffer_size + (read_buffer_size + sort_buffer_size)*max_threads = 467068 K  bytes of memory
Hope that's ok; if not, decrease some variables in the equation.

Thread pointer: 0x0x0
Attempting backtrace. You can use the following information to find out
where mysqld died. If you see no messages after this, something went
terribly wrong...
stack_bottom = 0x0 thread_stack 0x48000
/usr/libexec/mysqld(my_print_stacktrace+0x2b)[0xcb4ec6]
/usr/libexec/mysqld(handle_fatal_signal+0x2d8)[0x740464]
/lib64/libpthread.so.0(+0xf670)[0x7f3cada86670]
/lib64/libc.so.6(gsignal+0x39)[0x7f3cabffc979]
/lib64/libc.so.6(abort+0x148)[0x7f3cabffe088]
/lib64/libc.so.6(+0x2f966)[0x7f3cabff5966]
/lib64/libc.so.6(+0x2fa12)[0x7f3cabff5a12]
/usr/libexec/mysqld(_ZNK7handler6ha_thdEv+0x4e)[0x7456ae]
/usr/libexec/mysqld[0x9ce882]
/usr/libexec/mysqld(_ZN7handler8ha_closeEv+0xcf)[0x745801]
/usr/libexec/mysqld(_Z8closefrmP5TABLEb+0x91)[0x664963]
/usr/lib64/mysql/plugin/ha_oqgraph.so(_ZN10ha_oqgraph5closeEv+0x5e)[0x7f3caa9a3e5a]
/usr/libexec/mysqld(_ZN7handler8ha_closeEv+0xcf)[0x745801]
/usr/libexec/mysqld(_Z8closefrmP5TABLEb+0x91)[0x664963]
/usr/libexec/mysqld(_Z18intern_close_tableP5TABLE+0x10b)[0x564167]
/usr/libexec/mysqld(_Z8tc_purgeb+0x1a4)[0x6eec4d]
/usr/libexec/mysqld(_Z19close_cached_tablesP3THDP10TABLE_LISTbm+0x9a)[0x56f5ee]
/usr/libexec/mysqld(_Z18tdc_start_shutdownv+0x62)[0x6ec719]
/usr/libexec/mysqld[0x511d4b]
/usr/libexec/mysqld(_Z10unireg_endv+0xe)[0x516067]
/usr/libexec/mysqld[0x51b65c]
/usr/libexec/mysqld(kill_server_thread+0x13)[0x51b700]
/lib64/libpthread.so.0(+0x7ce2)[0x7f3cada7ece2]
/lib64/libc.so.6(clone+0x6d)[0x7f3cac0c08cd]
The manual page at http://dev.mysql.com/doc/mysql/en/crashing.html contains
information that should help you find out what is causing the crash.

Attachment: signature.asc
Description: This is a digitally signed message part.


Follow ups

References