← Back to team overview

oship-dev team mailing list archive

Re: OSHIP Rev 224 Code Review: issue #02 - Replace the view Setup() in app.py

 

on 24-3-2009 19:29 Tim Cook wrote:
I will comment on all of these.  Mostly as amplification for the
developer so that they know why I did what I did and it may save them
some time.


On Tue, 2009-03-24 at 12:18 +0100, Roger Erens wrote:
I think it should not be necessary to click on a link in order to create
the archetype repository (ar) and the terminology server (termserver)
containers.
Newbies don't know what that means, I guess.
So I think in app.py the class oship should have an __init__ method in
which those containers get created.


I think (from the examples I have read)

Do you have some pointers to them examples?

that an __init__ method may not
do what you expect.  The developer that takes on this issue will have to
do some in depth reading and experimentation.

Maybe it's the need to call the super(Oship, self).__init__()-method from within __init__(self) that's important to remember.


I do agree that this stuff should all be automatic.

--Tim






Follow ups

References