← Back to team overview

oship-dev team mailing list archive

Re: Good O'Ship and some bugs

 

Hi Eduardo,

I was intending to send you a thanks for the work.  But I am just returning
from a trip and haven't settled back in yet.

I took a quick look at the changes and the server seems to start okay, so I
assume the work is okay.   I was going to ask if you are now working on some
doctests?

The only thing I see  a bit odd is that you filed the bug report after you
made the fix and commit.  :-)

But do not worry about experimenting with Launchpad.  You can't hurt
anything we can't backout or fix.   It's all part of the learning curve.

Keep up the good work.

Cheers,
Tim


2009/11/8 Eduardo César <xcesar@xxxxxxxxx>

> Hi Tim,
>
> I had changed datastrutures.py in accordance with Data Structures Package
> Code Review that was assigned to me. Later I realized that it was to just
> report a bug, so I reported a bug and put it with a Fix commited too.
>
> Well, I guess need more practice with the Lauchpad system and with the
> community way of doing things. If I do something that you think could be
> harmful, please inform me :)
>
> Cheers
> Eduardo
>
>
>

Follow ups