oship-dev team mailing list archive

[noreply@xxxxxxxxxxxxx]

------------------------------------------------------------
revno: 458
committer: Eduardo César edu@starforge>
branch nick: local
timestamp: Fri 2010-08-06 12:52:03 -0300
message:
  Removed unecessary tests for type of arguments
modified:
  src/oship/rm/datatypes/basic/__init__.py
  src/oship/rm/datatypes/text/__init__.py
  src/oship/rm/datatypes/time_specification/__init__.py


--
lp:oship
https://code.launchpad.net/~oship-dev/oship/devel

Your team OSHIP Development Team is subscribed to branch lp:oship.
To unsubscribe from this branch go to https://code.launchpad.net/~oship-dev/oship/devel/+edit-subscription

=== modified file 'src/oship/rm/datatypes/basic/__init__.py'
--- src/oship/rm/datatypes/basic/__init__.py	2010-08-06 13:05:50 +0000
+++ src/oship/rm/datatypes/basic/__init__.py	2010-08-06 15:52:03 +0000
@@ -29,10 +29,7 @@
     grok.implements(IDvBoolean)
 
     def __init__(self, value):
-        if value == True or value == False:
-            self.value = value
-        else:
-            raise AttributeError("Invalid DvBoolean Value")
+        self.value = value
 
 
 class DvIdentifier(DataValue):
@@ -51,7 +48,7 @@
 
     def __init__(self, issuer, assigner, id_, type_):
             self.issuer = issuer
-            self.assignor = assignor
+            self.assigner = assigner
             self.id_ = id_
             self.type_ = type_
 
@@ -65,12 +62,5 @@
     grok.implements(IDvState)
 
     def __init__(self,value,isTerminal):
-        if isinstance(value,DvCodedText):
-            self.value=value
-        else:
-            raise AttributeError("DvState.value")
-
-        if isinstance(isTerminal,Bool):
-            self.isTerminal=isTerminal
-        else:
-            raise AttributeError("DvState.isTerminal")
+        self.value=value
+        self.isTerminal=isTerminal

=== modified file 'src/oship/rm/datatypes/text/__init__.py'
--- src/oship/rm/datatypes/text/__init__.py	2010-07-12 21:32:11 +0000
+++ src/oship/rm/datatypes/text/__init__.py	2010-08-06 15:52:03 +0000
@@ -116,11 +116,8 @@
     grok.implements(ICodePhrase)
 
     def __init__(self,terminologyId,codeString):
-        #if isinstance(terminologyId, TerminologyId) and isinstance(codeString,basestring):
-            self.terminologyId=terminologyId
-            self.codeString=codeString
-        #else:
-        #    raise AttributeError("CodePhrase attributes")
+        self.terminologyId=terminologyId
+        self.codeString=codeString
 
 
 class DvCodedText(DvText):
@@ -145,8 +142,6 @@
     grok.implements(IDvCodedText)
 
     def __init__(self,definingCode,value,mappings,formatting,hyperlink,language,encoding):
-        if isinstance(definingCode,CodePhrase):
-            self.definingCode=definingCode
-            DvText.__init__(self,value,mappings,formatting,hyperlink,language,encoding)
-        else:
-            raise AttributeError("DvCodedText.definingCode")
+        self.definingCode=definingCode
+        DvText.__init__(self,value,mappings,formatting,hyperlink,language,encoding)
+ 
\ No newline at end of file

=== modified file 'src/oship/rm/datatypes/time_specification/__init__.py'
--- src/oship/rm/datatypes/time_specification/__init__.py	2010-07-12 21:32:11 +0000
+++ src/oship/rm/datatypes/time_specification/__init__.py	2010-08-06 15:52:03 +0000
@@ -15,10 +15,7 @@
     grok.implements(IDvTimeSpecification)
 
     def __init__(self,value):
-        if isinstance(value,DvParsable):
-            self.value=value
-        else:
-            raise AttributeError("Invalid DvTimeSpecification.value")
+        self.value=value
 
     def calendarAlignment(self):
         u"""Indicates what prototypical point in the calendar the specification is