oship-dev team mailing list archive
-
oship-dev team
-
Mailing list archive
-
Message #01419
[Bug 603714] Re: Some issues related to LocatableRef.
** Changed in: oship
Status: In Progress => Fix Released
--
Some issues related to LocatableRef.
https://bugs.launchpad.net/bugs/603714
You received this bug notification because you are a member of OSHIP
Development Team, which is subscribed to Open Source Health Information
Platform.
Status in Open Source Health Information Platform (OSHIP): Fix Released
Bug description:
Class org.openehr.rm.support.identification.LocatableRef inherits from ObjectRef but redefines its attribute id to be an instance of UidBasedId instead of ObjectId.
In the implementation the interface ILocatableRef defined another attribute id_. Is this the correct way to do it, or should we only redefine id here.
The initializer of LocatableRef has an argument refId. What does it mean? It seems to be superfluous, since LocatableRef does not have two id attributes, it only redefines the id attribute. If we only need to have a single attribute id, then it will be necessary to fix methods asUri and __eq__.
It is also necessary to implement __hash__ method.
References