oship-dev team mailing list archive
-
oship-dev team
-
Mailing list archive
-
Message #01539
[Bug 623581] Re: issues in class Link in the common package
Sorry, but the bug isn't completed yet :
1. There isn't any tests that verify the implemented behavior. It's a simple class but any class needs tests.
2. Link objects also can be included into a python set collection. so it's mandatory include the __hash__ and __eq__ methods in order to provide Link objects as set members [1] .
3. It must inherit from persistent.Persistent allowing be stored on the the ZODB [2] .
[1] - http://docs.python.org/reference/datamodel.html#object.__hash__
[2] - http://zodb.org/documentation/guide/prog-zodb.html#writing-a-persistent-class
status incomplete
** Changed in: oship
Status: Fix Released => Incomplete
--
issues in class Link in the common package
https://bugs.launchpad.net/bugs/623581
You received this bug notification because you are a member of OSHIP
Development Team, which is subscribed to Open Source Health Information
Platform.
Status in Open Source Health Information Platform (OSHIP): Incomplete
Bug description:
It seems that meaningValid, typeValid and targetValid in ILink interface are not necessary, since the attributes meaning, type and target are already required in the respective schemas.
Link does not inherit from Locatable.
References