← Back to team overview

oship-dev team mailing list archive

[Bug 619314] Re: issues in class Actor from the demographic package

 

** Project changed: oship => oshippy

-- 
You received this bug notification because you are a member of OSHIP
Development Team, which is subscribed to Open Source Health Information
Platform.
https://bugs.launchpad.net/bugs/619314

Title:
  issues in class Actor from the demographic package

Status in Open Source Health Information Platform - Python:
  New

Bug description:
  The initializer lacks the argument parent and so does the superclass initializer..
  wouldn't be interesting to define a representation function for this class?
  The invariants should be enforce:
  Roles_valid: roles /= Void implies not roles.is_empty
  Languages_valid: languages /= Void implies not languages.is_empty

  The issues below should be considered in a new MLHIM version:
    	 The invariant Legal_identity_exists in class org.openehr.rm.demographic.Actor seems too restrictive. While it is expected that every actor has at least an identity with the purpose "legal identity", there may be situations where one has to register a person that has not a known legal name at the moment of registration, for example, a newborn who is not registered yet or an unconscious person in a emergency room and without any identification.

  My suggestion is to remove this invariant from the specifications.

           The function has_legal_identity in class
  org.openehr.rm.demographic.Actor seems to be misspecified. The
  function has_legal_identity returns True if there is an identity with
  purpose "legal identity". This condition should be expressed in a
  language independent way. In ISO 22220, it is referred not as "legal
  identity" but as "registered name or legal name".

   I think that this function should be left out of the specifications
  since it application and terminology dependent.





References