oshippy-dev team mailing list archive

Thread
Date

[Bug 606383] [NEW] seemingly unnecessary assignments in the initializer of class Cluster

To: oshippy-dev@xxxxxxxxxxxxxxxxxxx
From: Launchpad Bug Tracker <606383@xxxxxxxxxxxxxxxxxx>
Date: Mon, 14 Feb 2011 23:05:04 -0000
Reply-to: Bug 606383 <606383@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

You have been subscribed to a public bug:

 The following assignments in the initializer of class Cluster seems unnecessary since they are done in the initializer of the superclass, aren't they?
       self.uid = uid
        self.atnodeid = archetypeNodeId
        self.name = name
        self.atdetails = archetypeDetails
        self.fdraudit = feederAudit
        self.parent = parent

It seems that only self.items should be retained.

I think we should be consistent in the call to the superclass initializer: 
Compare the call    super(Cluster, self).__init__(uid, archetypeNodeId, name, archetypeDetails, feederAudit, links, parent)
in class Cluster 
with the call  Locatable.__init__(self, uid, archetypeNodeId, name, archetypeDetails, feederAudit, links)
in class Item.

** Affects: oshippy
     Importance: Low
     Assignee: Eduardo César (xcesar)
         Status: Fix Released

-- 
seemingly unnecessary assignments in the initializer of class Cluster
https://bugs.launchpad.net/bugs/606383
You received this bug notification because you are a member of OSHIPpy Developers, which is subscribed to OSHIPpy.