oshippy-dev team mailing list archive

Thread
Date

[Bug 612572] Re: several issues in DvDuration

To: oshippy-dev@xxxxxxxxxxxxxxxxxxx
From: Diego Manhães Pinheiro <612572@xxxxxxxxxxxxxxxxxx>
Date: Mon, 14 Feb 2011 23:02:18 -0000
Reply-to: Bug 612572 <612572@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

** Project changed: oship => oshippy

-- 
You received this bug notification because you are a member of OSHIPpy
Developers, which is subscribed to OSHIPpy.
https://bugs.launchpad.net/bugs/612572

Title:
  several issues in DvDuration

Status in Open Source Health Information Platform - Python:
  Fix Released

Bug description:
  Argument magnitudeStatus is missing in the initializer and in the call to the superclass initializer.
  magnitude is an derived attribute, so it does not need to appear as an argument in the initializer. It should be assigned the correct value in seconds based on the value attribute.
  It is necessary to make a thorough check on the validity of the value argument in the initialization, which means that valueValid invariant should be fully implemented.

  DvDuration inherits from DvAmount and ISO8601Duration (support package). So it is necessary to implement all methods of both classes, namely:
        add, subtract, negate, compare, isStrictlyComparableTo (DvAmount)
       asString, years, months, weeks, days, hours, minutes, seconds, fractionalSecond, is_decimal_sign_comma, toSeconds (ISO8601Duration)