← Back to team overview

ourdelta-developers team mailing list archive

Re: [Bug 284724] Re: Google SMP patches (5.0 and 5.1)

 

Which patch do you want?
1) SMP fix
2) configurable number of background IO threads
3) configurable background IO rate limit
4) disable Innodb malloc heap in mem/mem0pool.c

For 1 -- Percona just repoted a performance regression in the Google
code. Percona uses the Yasufumi version of faster rw-mutex that The
Yasufumi version doesn't have that problem.

For 2 -- Percona uses the Yasufumi version.

For 3 -- Percona has their own change or uses the Yasufumi version.
>From the description of the Percona version, the Google version might
be more general, but I have not looked at their code. The Google
version is in the 5.0-map launchpad branch that I publish.

For 4 -- this is trivia to port.

You might want to try to use 3.
You should use 4.
I think that 1 and 2 from the Google patch are redundant with existing
Percona patches.

The regression for 1 occurs when there are many concurrent connections
doing updates. We just started to look at it today.

On Thu, Oct 16, 2008 at 6:22 PM, Arjen Lentz <arjen@xxxxxxxxxxxxxxxx> wrote:
> Little task free for anybody to pick up and do!
>
> ** Changed in: ourdelta
>   Importance: Undecided => Wishlist
>       Status: New => Confirmed
>
> --
> Google SMP patches (5.0 and 5.1)
> https://bugs.launchpad.net/bugs/284724
> You received this bug notification because you are a member of OurDelta-
> developers, which is the registrant for OurDelta.
>
> Status in OurDelta - Builds for MySQL: Confirmed
>
> Bug description:
> See http://code.google.com/p/google-mysql-tools/wiki/Mysql5Patches
> Get the 5.0 and 5.1 patches into the ourdelta tree, add patch_info (for SHOW PATCHES).
>
> See if/how they conflict with the Yasufumi Kinoshita patches in 5.0-Sail. If no intrinsic conflict, we can have them both enabled in Sail to see what that does for performance, and have just SMP in the regular build also as I'd regard the Google patch to be real-world tested sufficiently, and many people can benefit.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~ourdelta-developers
> Post to     : ourdelta-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~ourdelta-developers
> More help   : https://help.launchpad.net/ListHelp
>



-- 
Mark Callaghan
mdcallag@xxxxxxxxx



Follow ups

References