← Back to team overview

ourdelta-developers team mailing list archive

[Bug 290190] Re: mysqld_safe does not honour underscores in options like mysqld does

 

(Pasting your note from email)
> in revision 38 there's a slight alteration for Solaris (ironically enough not the sed line). 
> Basically, instead of $() it's using backticks which is compatible with Solaris' /bin/sh

> But the patch you pasted works for any Linux distro and FreeBSD version 
> conceived on this side of the moon landing.

Ok, great work - but... ;-)
I think we need to patch this in a different spot: extra/my_print_defaults.c
Then any other scripts/tools that use the same will also be fixed, rather than just mysqld_safe.
Also, some distros replace/patch mysqld_safe (have their own foo) but the my_print_defaults binary should always be around and get updated.

I would suggest we fix this in main() in or just before the loop that outputs the params:
  for (argument= arguments+1 ; *argument ; argument++)
    puts(*argument);

-- 
mysqld_safe does not honour underscores in options like mysqld does
https://bugs.launchpad.net/bugs/290190
You received this bug notification because you are a member of OurDelta-
developers, which is the registrant for OurDelta.

Status in OurDelta - Builds for MySQL: Confirmed

Bug description:
mysqld accepts both dashes and underscores in server options, however mysqld_safe does not.
Since it's unclear from the user's perspective (and they shouldn't NEED to know!) which options get processed only by mysqld_safe, this can mean that they use an option in the wrong way but don't notice it.
Example... open_files_limit
When written like that, it mysqld_safe will not recognise it and thus not call ulimit -n
...
The option WILL be feed to mysqld so it shows the "correct" number in SHOW GLOBAL VARIABLES. Except, since ulimit wasn't called, it's not actually in effect!

See http://bugs.mysql.com/40368



References