← Back to team overview

ourdelta-developers team mailing list archive

Re: [Bug 454254] Re: deb package tries to add innodb, federated, blackhole as plugins while they arent

 

Hi mark

On 19/10/2009, at 6:08 AM, Mark Callaghan wrote:
> Why have the built-in and plug-in versions of InnoDB been disabled?  
> Disabled means I cannot compile them with MariaDB.

Ah, and you'd like to pehaps include your own InnoDB plugin? If we  
leave 'em enabled, funny thnigs happen with tests and such. As  
Kristian mentioned, it may well be possible to make it work, but it  
was a bit finicky hence this approach for now.

> And why does XtraDB use the plugin name 'innobase' rather than  
> 'xtradb' or 'xtradb_plugin'?
> Built-in InnoDB uses the name 'innobase' and plug-in InnoDB uses the  
> name 'innodb_plugin'.

That's a fair question, and perhaps Percona has an answer to that.
I presume that even if it were called XtraDB, the options could still  
also be called innodb_ for backward compatibility.

It's possible (or even likely) that XtraDB using the source names it  
has causes the build problem...


> See storage/innobase/plug.in.disabled,
> storage/innodb_plugin/plug.in.disabled, storage/xtradb/plug.in


Yep.


Cheers,
Arjen.
-- 
Arjen Lentz, Exec.Director @ Open Query (http://openquery.com)
Exceptional Services for MySQL at a fixed budget.

Follow our blog at http://openquery.com/blog/
OurDelta: enhanced builds for MySQL @ http://ourdelta.org

-- 
deb package tries to add innodb,federated,blackhole as plugins while they arent
https://bugs.launchpad.net/bugs/454254
You received this bug notification because you are a member of OurDelta-
developers, which is the registrant for OurDelta.

Status in Maria: Fix Committed
Status in OurDelta - Builds for MySQL,MariaDB: New

Bug description:
ourdelta-mariadb51-2/bakery/debian-5.1/dist/Ubuntu/mariadb-server-5.1.postinst has this:

        "CREATE TABLE plugin (name char(64) COLLATE utf8_bin NOT NULL DEFAULT '', " \
        "  dl char(128) COLLATE utf8_bin NOT NULL DEFAULT '', " \
        "  PRIMARY KEY (name)) ENGINE=MyISAM DEFAULT CHARSET=utf8 COLLATE=utf8_bin COMMENT='MySQL plugins';\n" \
        "INSERT INTO plugin VALUES ('innodb',    'ha_innodb.so');\n" \
        "INSERT INTO plugin VALUES ('federated', 'ha_federated.so');\n" \
        "INSERT INTO plugin VALUES ('blackhole', 'ha_blackhole.so');\n" \
        "INSERT INTO plugin VALUES ('archive',   'ha_archive.so');" `

But when I unpack all of mariadb .deb files, I find only one plugin - ha_example.so.  innodb, blackhole, archive seem to be compiled statically, federated seems to be compiled dynamically but missing.

The build and postinst script should be brought in sync.



Follow ups

References