percona-discussion team mailing list archive

[Arjen Lentz <arjen@xxxxxxxxxxxxx>]

Hi Vadim

On 26/09/2009, at 9:57 AM, Vadim Tkachenko wrote:
> I think the patch is already included, isn't it ?

Nope, not in your lp 5.0.86 patch branch I just pulled.
The situation is as described below, the USER field is not patched and  
the CLIENT field uses a different define.

Cheers,
Arjen.


> On Fri, Sep 25, 2009 at 4:38 PM, Arjen Lentz <arjen@xxxxxxxxxxxxx>  
> wrote:
> > Hi Vadim
> >
> > Please merge this in (sorry the paths are from the ourdelta tree,  
> > but the
> > offset within the file is compatible with yours)
> >
> > === modified file 'mysql/5.0/percona_maintained/userstatv2.patch'
> > --- mysql/5.0/percona_maintained/userstatv2.patch       2009-09-25  
> > 23:16:39
> > +0000
> > +++ mysql/5.0/percona_maintained/userstatv2.patch       2009-09-25  
> > 23:28:28
> > +0000
> > @@ -3901,7 +3901,7 @@
> >
> >  +ST_FIELD_INFO user_stats_fields_info[]=
> >  +{
> > -+  {"USER", 16, MYSQL_TYPE_STRING, 0, 0, "User"},
> > ++  {"USER", USERNAME_LENGTH, MYSQL_TYPE_STRING, 0, 0, "User"},
> >
> >
> >
> > By the way, his fix for the CLIENT field was HOSTNAME_LENGTH (60)  
> > whereas
> > you used LIST_PROCESS_HOST_LEN (64)
> > In the mysql.user table the host field is a CHAR(60), so I'm  
> > guessing that
> > Neil picked the correct macro.
> > Harmless in this case, now, but might as well use the proper macro  
> > because
> > if anything else changes later it could break.



--
Arjen Lentz, Exec.Director @ Open Query (http://openquery.com)
Exceptional Services for MySQL at a fixed budget.

Follow our blog at http://openquery.com/blog/
OurDelta: enhanced builds for MySQL @ http://ourdelta.org