phatch-dev team mailing list archive

[stani <spe.stani.be@xxxxxxxxx>]

Juho, did you actually try this one? It is full of errors :-(
- your regular expressions (eg '!input!') are not right, please look up the right ones. Please compile the regular expressions and make them available as class attribute. 
- never use image.filename, normally you would pass info['path'] as an argument but in this case both input and output need to be temporary files. Save the current pil image (photo.get_layer().image) as a temporary file and pass its temporary name to the 
re.sub('!input!', image.filename, command)
- Also don't use the deprecated os.system, but do:
from subprocess import call
call('command',shell=True)

Hmmm... maybe it is better I do this. By the time I have explained all
the errors, I've done it myself. In case you don't know how to do
something it is better to ask before submitting the patch.

Thanks a lot anyway for trying! Really!

** Changed in: phatch
       Status: New => Incomplete

** Changed in: phatch
     Assignee: (unassigned) => stani (stani)

-- 
Implementation of "Command line action with themporary files or pipes"
https://bugs.launchpad.net/bugs/386682
You received this bug notification because you are a member of Phatch
Developers, which is subscribed to Phatch.

Status in Phatch = Photo & Batch!: Incomplete

Bug description:
This patch implements https://blueprints.launchpad.net/phatch/+spec/command-line-action .