← Back to team overview

phatch-dev team mailing list archive

[Bug 386741] Re: Implementation of "Time shift action"

 

** Description changed:

  This patch implements https://blueprints.launchpad.net/phatch/+spec
  /time-shift-action .
  
- Note that this action as well as other actions related to metadata seem
- to modify original input images in any case (ie. even if save action is
- provided). I'm not convinced this is a good default behavior as it's
- easy to mess up metadata of your original files easily this way. (Result
- does not match expectation as Phatch works in non-destructive way with
- images. :) )
+ Juho: Note that this action as well as other actions related to metadata
+ seem to modify original input images in any case (ie. even if save
+ action is provided). I'm not convinced this is a good default behavior
+ as it's easy to mess up metadata of your original files easily this way.
+ (Result does not match expectation as Phatch works in non-destructive
+ way with images. :) )
+ 
+ Stani: At the moment the design is that the metadata actions should
+ modify the source image is the metadata action is placed *before* the
+ save action. So this is totally intended at the moment. When it is
+ placed *after* the save action, it will modify only the saved file. See
+ the phatch-dev mailing list. This behavior will change soon to a better
+ approach.

-- 
Implementation of "Time shift action"
https://bugs.launchpad.net/bugs/386741
You received this bug notification because you are a member of Phatch
Developers, which is subscribed to Phatch.

Status in Phatch = Photo & Batch!: New

Bug description:
This patch implements https://blueprints.launchpad.net/phatch/+spec/time-shift-action .

Juho: Note that this action as well as other actions related to metadata seem to modify original input images in any case (ie. even if save action is provided). I'm not convinced this is a good default behavior as it's easy to mess up metadata of your original files easily this way. (Result does not match expectation as Phatch works in non-destructive way with images. :) )

Stani: At the moment the design is that the metadata actions should modify the source image is the metadata action is placed *before* the save action. So this is totally intended at the moment. When it is placed *after* the save action, it will modify only the saved file. See the phatch-dev mailing list. This behavior will change soon to a better approach.



Follow ups

References