phatch-dev team mailing list archive

[stani <spe.stani.be@xxxxxxxxx>]

Hi Juho,

Please remove the _set_photo_date method() it seems irrelevant. It makes indeed little sense to modify filetime. I remember an user asking for it as he liked to have the exif and file times synchronized. If we want to implement it, we would need to add two extra fields:
- ChoiceField Source: Exif or File
- ChoiceField Target: Both, Exif or File

Moreover we would need to store the datetime in the photo object and
modify photo.save it uses it. Maybe this is too much work and we could
extend it, when there is a demand for it. So leave it for now, we have
more important things to do.

You should have mentioned that you wanted to include a module and put the right copyright information in phatch/copyright:
$ bzr diff copyright
=== modified file 'copyright'
--- copyright	2009-06-11 16:44:23 +0000
+++ copyright	2009-06-15 05:34:58 +0000
@@ -156,6 +156,16 @@
    http://www.python.org/ftp/python/contrib-09-Dec-1999/DataStructures/
 
    
+The file phatch/other/relativedelta.py is a source file of dateutil and is
+licensed under its license:
+
+   Copyright (c) 2003-2007  Gustavo Niemeyer <gustavo@xxxxxxxxxxxx>
+
+   This module offers extensions to the standard python 2.3+
+   datetime module.
+   
+   PSF License
+
 The file phatch/other/findsystem.py is a source file of TTFQuery-1.0.1 and is
 licensed under its license:

In this case there is no problem as it is compatible with the GPL. It is now added to phatch/other so you can import it with
>>> from relativedelta import relativedelta

Can you please attach an updated fix?

** Changed in: phatch
       Status: New => Incomplete

** Changed in: phatch
     Assignee: (unassigned) => Juho Vepsäläinen (bebraw)

-- 
Implementation of "Time shift action"
https://bugs.launchpad.net/bugs/386741
You received this bug notification because you are a member of Phatch
Developers, which is subscribed to Phatch.

Status in Phatch = Photo & Batch!: Incomplete

Bug description:
This patch implements https://blueprints.launchpad.net/phatch/+spec/time-shift-action .

Juho: Note that this action as well as other actions related to metadata seem to modify original input images in any case (ie. even if save action is provided). I'm not convinced this is a good default behavior as it's easy to mess up metadata of your original files easily this way. (Result does not match expectation as Phatch works in non-destructive way with images. :) )

Stani: At the moment the design is that the metadata actions should modify the source image is the metadata action is placed *before* the save action. So this is totally intended at the moment. When it is placed *after* the save action, it will modify only the saved file. See the phatch-dev mailing list. This behavior will change soon to a better approach.