phatch-dev team mailing list archive

[Juho Vepsäläinen <bebraw@xxxxxxxxx>]

I removed the redundant _set_photo_date method. I must have forgotten it
there before I figured out I can use datetime directly. I agree that
it's better to implement enhanced functionality at some other time. I
suppose "time shift", as it is, manages to be useful to some extent.

Good point about including a module.

It would be good to trigger "Image Inspector" update after executing the
action list. (Perhaps do this in any case for time being?) As I am not
familiar with the way it works perhaps this is something you could look
into (supposed it proves to be easy enough fix :) ).

** Attachment added: "updated patch"
   http://launchpadlibrarian.net/27922734/time_shift2.txt

-- 
Implementation of "Time shift action"
https://bugs.launchpad.net/bugs/386741
You received this bug notification because you are a member of Phatch
Developers, which is subscribed to Phatch.

Status in Phatch = Photo & Batch!: Incomplete

Bug description:
This patch implements https://blueprints.launchpad.net/phatch/+spec/time-shift-action .

Juho: Note that this action as well as other actions related to metadata seem to modify original input images in any case (ie. even if save action is provided). I'm not convinced this is a good default behavior as it's easy to mess up metadata of your original files easily this way. (Result does not match expectation as Phatch works in non-destructive way with images. :) )

Stani: At the moment the design is that the metadata actions should modify the source image is the metadata action is placed *before* the save action. So this is totally intended at the moment. When it is placed *after* the save action, it will modify only the saved file. See the phatch-dev mailing list. This behavior will change soon to a better approach.