← Back to team overview

phatch-dev team mailing list archive

[Bug 386741] Re: Implementation of "Time shift action"

 

Hi Juho, for the tile action I proposed that Nadia could implement the
icon. Now you are so productive, it is better to learn to do it yourself
as I don't want to turn Nadia into an icon convertor. So please look for
the actions, which you contribute, for a nice shiny, glossy icon which
fits with the rest of Phatch. The icon should be compatible with the
GPL, so no creative commons! The most easy is to take one from the
openclip art library, as they are public domain. As a suggestion, for
this action you could you use a chronometer icon or a clock. I'm sure
you'll find something ;-) Please also add icons to your previous
actions. I'll mark them as incomplete to keep track. Also send a mail to
Dwarrel to document your actions, give a bit of info if needed.

For howto on embedding, see (only works with wx2.6, not wx2.8):
python /usr/lib/python2.4/site-packages/wx-2.6-gtk2-unicode/wx/tools/img2py.py highlight_plugin_icon.png icon.py
http://photobatch.wikidot.com/writing-actions

I've committed it to trunk already:
$ bzr commit -m "added time shift action"
Committing to: /home/stani/sync/python/phatch/trunk/                           
added phatch/actions/time_shift.py                                             
Committed revision 775.

-- 
Implementation of "Time shift action"
https://bugs.launchpad.net/bugs/386741
You received this bug notification because you are a member of Phatch
Developers, which is subscribed to Phatch.

Status in Phatch = Photo & Batch!: Incomplete

Bug description:
This patch implements https://blueprints.launchpad.net/phatch/+spec/time-shift-action .

Juho: Note that this action as well as other actions related to metadata seem to modify original input images in any case (ie. even if save action is provided). I'm not convinced this is a good default behavior as it's easy to mess up metadata of your original files easily this way. (Result does not match expectation as Phatch works in non-destructive way with images. :) )

Stani: At the moment the design is that the metadata actions should modify the source image is the metadata action is placed *before* the save action. So this is totally intended at the moment. When it is placed *after* the save action, it will modify only the saved file. See the phatch-dev mailing list. This behavior will change soon to a better approach.



References