← Back to team overview

phatch-dev team mailing list archive

Re: [Bug 516763] Re: Lossless rotate doesn't work

 

I've just started to follow phatch development.
Your suggestions are right and they solve the problem, I modified the
code and it doesn't provoke that error anymore.

I tried to create a patch but it's the first time I use bzr, i'm
putting it in attachment, tell me if I "packaged" it correctly.

--
Andrea

2010/2/5 Juho Vepsäläinen <bebraw@xxxxxxxxx>:
> I will look into setting up a virtual machine (Ubuntu most likely)
> during weekend. I don't mind if someone else wants to give proposed
> fixes a go, though. :)
>
> --
> Lossless rotate doesn't work
> https://bugs.launchpad.net/bugs/516763
> You received this bug notification because you are subscribed to Phatch.
>
> Status in Phatch = Photo & Batch!: Confirmed
>
> Bug description:
> Hi Juho, can you provide a patch for this?
>
> Error 0:Can not apply action Lossless JPEG on image 'IMG_8763.JPG' in folder:
> /home/stani/sync/2010/woningen/verkoop/foto's
>
> super(type, obj): obj must be an instance or subtype of type
>
> Action:{'fields': {'All': '30%',
>            'Angle': u'270 degrees',
>            'Angle ': '90 degrees',
>            'Bottom': '0px',
>            'Copy': 'Comments',
>            'Direction': 'Horizontal',
>            'Direction ': 'Horizontal',
>            'File Name': u'<filename>_phatch',
>            'In': u'<folder>/<subfolder>',
>            'Left': '0px',
>            'Mode': 'All',
>            'Preserve Timestamp': 'yes',
>            'Right': '0px',
>            'Show Advanced Options': 'no',
>            'Top': '0px',
>            'Transformation': u'Rotate',
>            'Transformation ': 'Crop',
>            'Update Exif Thumbnail': 'yes',
>            'Update JPEG': 'yes',
>            'Update Orientation Tag': 'yes',
>            'Utility': 'Exiftran (with exif support)',
>            '__enabled__': 'yes'},
>  'label': 'Lossless JPEG'}
>
> Traceback (most recent call last):
>  File "/usr/lib/python2.6/dist-packages/phatch/core/api.py", line 609, in apply_action_to_photo
>    photo = action.apply(photo, read_only_settings, cache)
>  File "/usr/lib/python2.6/dist-packages/phatch/actions/lossless_jpeg.py", line 261, in apply
>    self.call(photo,info,utility)
>  File "/usr/lib/python2.6/dist-packages/phatch/actions/lossless_jpeg.py", line 275, in call
>    super(JpegUtility, self).execute(photo)
> TypeError: super(type, obj): obj must be an instance or subtype of type
> *
>
>
>


** Attachment added: "fix-516763.txt"
   http://launchpadlibrarian.net/38793153/fix-516763.txt

-- 
Lossless rotate doesn't work
https://bugs.launchpad.net/bugs/516763
You received this bug notification because you are a member of Phatch
Developers, which is subscribed to Phatch.

Status in Phatch = Photo & Batch!: Confirmed

Bug description:
Hi Juho, can you provide a patch for this?

Error 0:Can not apply action Lossless JPEG on image 'IMG_8763.JPG' in folder:
/home/stani/sync/2010/woningen/verkoop/foto's

super(type, obj): obj must be an instance or subtype of type

Action:{'fields': {'All': '30%',
            'Angle': u'270 degrees',
            'Angle ': '90 degrees',
            'Bottom': '0px',
            'Copy': 'Comments',
            'Direction': 'Horizontal',
            'Direction ': 'Horizontal',
            'File Name': u'<filename>_phatch',
            'In': u'<folder>/<subfolder>',
            'Left': '0px',
            'Mode': 'All',
            'Preserve Timestamp': 'yes',
            'Right': '0px',
            'Show Advanced Options': 'no',
            'Top': '0px',
            'Transformation': u'Rotate',
            'Transformation ': 'Crop',
            'Update Exif Thumbnail': 'yes',
            'Update JPEG': 'yes',
            'Update Orientation Tag': 'yes',
            'Utility': 'Exiftran (with exif support)',
            '__enabled__': 'yes'},
 'label': 'Lossless JPEG'}

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/phatch/core/api.py", line 609, in apply_action_to_photo
    photo = action.apply(photo, read_only_settings, cache)
  File "/usr/lib/python2.6/dist-packages/phatch/actions/lossless_jpeg.py", line 261, in apply
    self.call(photo,info,utility)
  File "/usr/lib/python2.6/dist-packages/phatch/actions/lossless_jpeg.py", line 275, in call
    super(JpegUtility, self).execute(photo)
TypeError: super(type, obj): obj must be an instance or subtype of type
*





References