← Back to team overview

phatch-dev team mailing list archive

[Bug 526047] Re: [Mac] Menu separator is not needed under Export menu

 

$ bzr diff
=== modified file 'phatch/pyWx/gui.py'
--- phatch/pyWx/gui.py	2010-02-04 11:56:34 +0000
+++ phatch/pyWx/gui.py	2010-02-23 06:07:48 +0000
@@ -361,7 +361,6 @@
         self.menu_file_export = \
             self.menu_file_export_actionlist_to_clipboard.GetMenu()
         #file history
-        self.menu_file.AppendSeparator()
         self.menu_file_recent = wx.Menu()
         self.filehistory = wx.FileHistory()
         self.filehistory.UseMenu(self.menu_file_recent)
@@ -426,6 +425,8 @@
             app.SetMacAboutMenuItemId(wx.ID_ABOUT)
             app.SetMacExitMenuItemId(wx.ID_EXIT)
             #app.SetMacPreferencesMenuItemId(wx.ID_PREFERENCES)
+        else:
+            self.menu_file.InsertSeparator(8)
     def _title(self):
         path, filename = os.path.split(self.filename)
         self.SetTitle(ct.FRAME_TITLE\

=== modified file 'phatch/pyWx/wxGlade/frame.py'
--- phatch/pyWx/wxGlade/frame.py	2009-10-11 16:51:58 +0000
+++ phatch/pyWx/wxGlade/frame.py	2010-02-23 06:08:18 +0000
@@ -59,7 +59,6 @@
         self.menu_file_export_inspector_to_clipboard = wx.MenuItem(menu_file_export, wx.NewId(), _("Copy Image I&nspector as Command to Clipboard"), _("Paste this command in a launcher"), wx.ITEM_NORMAL)
         menu_file_export.AppendItem(self.menu_file_export_inspector_to_clipboard)
         self.menu_file.AppendMenu(wx.ID_FORWARD, _("&Export"), menu_file_export, "")
-        self.menu_file.AppendSeparator()
         self.menu_file_quit = wx.MenuItem(self.menu_file, wx.ID_EXIT, _("&Quit\tCtrl-Q"), _("Quit the application."), wx.ITEM_NORMAL)
         self.menu_file.AppendItem(self.menu_file_quit)
         self.frame_menubar.Append(self.menu_file, _("&Action List"))

=== modified file 'phatch/pyWx/wxGlade/frame.wxg'
--- phatch/pyWx/wxGlade/frame.wxg	2009-10-11 16:51:58 +0000
+++ phatch/pyWx/wxGlade/frame.wxg	2010-02-23 06:08:17 +0000
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<!-- generated by wxGlade 0.6.3 on Sun Oct 11 17:05:06 2009 -->
+<!-- generated by wxGlade 0.6.3 on Tue Feb 23 01:08:17 2010 -->
 
 <application path="frame.py" name="app" class="App" option="0" language="python" top_window="frame" encoding="UTF-8" use_gettext="1" overwrite="0" use_new_namespace="1" for_version="2.6" is_template="0">
     <object class="Frame" name="frame" base="EditFrame">
@@ -70,11 +70,6 @@
                         </item>
                     </menu>
                     <item>
-                        <label>---</label>
-                        <id>---</id>
-                        <name>---</name>
-                    </item>
-                    <item>
                         <label>&amp;Quit\tCtrl-Q</label>
                         <id>wx.ID_EXIT</id>
                         <name>menu_file_quit</name>

stani@x9150:~/sync/python/phatch/repo/trunk/phatch$ bzr commit -m "remove last separator from file menu [mac]"
Committing to: /home/stani/sync/python/phatch/repo/trunk/                      
modified phatch/pyWx/gui.py
modified phatch/pyWx/wxGlade/frame.py
modified phatch/pyWx/wxGlade/frame.wxg
Committed revision 1557.

** Changed in: phatch
       Status: Confirmed => Fix Committed

-- 
[Mac] Menu separator is not needed under Export menu
https://bugs.launchpad.net/bugs/526047
You received this bug notification because you are a member of Phatch
Developers, which is subscribed to Phatch.

Status in Phatch = Photo & Batch!: Fix Committed

Bug description:
It looks ugly.





References