← Back to team overview

phatch-dev team mailing list archive

[Bug 526057] Re: [Mac] Library dialog is not ok

 

** Description changed:

+ - select button does not have enough space around it
  - size should be adjusted so 2 rows are shown
- - select button does not have enough space around it
+ 
+ The relevant code for the space around the button is in lib/pyWx/imageFileBrowser.py (line 115):
+         #buttons
+         btn_sizer = wx.BoxSizer(wx.HORIZONTAL)
+         b = 6
+         btn_sizer.Add(self.status, 1, wx.ALL | wx.ALIGN_CENTER_VERTICAL, b)
+         btn_sizer.Add(self.cancel, 0, wx.ALL | wx.ALIGN_CENTER_VERTICAL, b)
+         btn_sizer.Add(self.ok, 0, wx.ALL | wx.ALIGN_CENTER_VERTICAL, b)
+         sizer.Add(btn_sizer, 0, wx.EXPAND, 0)
+ 
+ Now the space should be 6px as specified by 'b=6'. To increase the size
+ give a higher value
+ 
+ The relevant code for the size is in pyWx/gui.py (line 645):
+             self.dlg_library = imageFileBrowser.Dialog(
+                 parent=self,
+                 files=self.library_files_dictionary,
+                 title=_('Library Action Lists'),
+                 size=(self.GetSize()[0], 370),
+                 icon_size=(128, 128))
+        (...)
+ 
+ -> You need to replace 370 with a higher value until two rows of
+ thumbnails are visible. So what is this value?

** Description changed:

  - select button does not have enough space around it
  - size should be adjusted so 2 rows are shown
  
  The relevant code for the space around the button is in lib/pyWx/imageFileBrowser.py (line 115):
-         #buttons
-         btn_sizer = wx.BoxSizer(wx.HORIZONTAL)
-         b = 6
-         btn_sizer.Add(self.status, 1, wx.ALL | wx.ALIGN_CENTER_VERTICAL, b)
-         btn_sizer.Add(self.cancel, 0, wx.ALL | wx.ALIGN_CENTER_VERTICAL, b)
-         btn_sizer.Add(self.ok, 0, wx.ALL | wx.ALIGN_CENTER_VERTICAL, b)
-         sizer.Add(btn_sizer, 0, wx.EXPAND, 0)
+         #buttons
+         btn_sizer = wx.BoxSizer(wx.HORIZONTAL)
+         b = 6
+         btn_sizer.Add(self.status, 1, wx.ALL | wx.ALIGN_CENTER_VERTICAL, b)
+         btn_sizer.Add(self.cancel, 0, wx.ALL | wx.ALIGN_CENTER_VERTICAL, b)
+         btn_sizer.Add(self.ok, 0, wx.ALL | wx.ALIGN_CENTER_VERTICAL, b)
+         sizer.Add(btn_sizer, 0, wx.EXPAND, 0)
  
  Now the space should be 6px as specified by 'b=6'. To increase the size
  give a higher value
  
  The relevant code for the size is in pyWx/gui.py (line 645):
-             self.dlg_library = imageFileBrowser.Dialog(
-                 parent=self,
-                 files=self.library_files_dictionary,
-                 title=_('Library Action Lists'),
-                 size=(self.GetSize()[0], 370),
-                 icon_size=(128, 128))
-        (...)
+             self.dlg_library = imageFileBrowser.Dialog(
+                 parent=self,
+                 files=self.library_files_dictionary,
+                 title=_('Library Action Lists'),
+                 size=(self.GetSize()[0], 370),
+                 icon_size=(128, 128))
+        (...)
  
  -> You need to replace 370 with a higher value until two rows of
  thumbnails are visible. So what is this value?
+ 
+ Please attach a screenshot so I can evaluate the result.
+ 
+ Thanks!

-- 
[Mac] Library dialog is not ok
https://bugs.launchpad.net/bugs/526057
You received this bug notification because you are a member of Phatch
Developers, which is subscribed to Phatch.

Status in Phatch = Photo & Batch!: Confirmed

Bug description:
- select button does not have enough space around it
- size should be adjusted so 2 rows are shown

The relevant code for the space around the button is in lib/pyWx/imageFileBrowser.py (line 115):
        #buttons
        btn_sizer = wx.BoxSizer(wx.HORIZONTAL)
        b = 6
        btn_sizer.Add(self.status, 1, wx.ALL | wx.ALIGN_CENTER_VERTICAL, b)
        btn_sizer.Add(self.cancel, 0, wx.ALL | wx.ALIGN_CENTER_VERTICAL, b)
        btn_sizer.Add(self.ok, 0, wx.ALL | wx.ALIGN_CENTER_VERTICAL, b)
        sizer.Add(btn_sizer, 0, wx.EXPAND, 0)

Now the space should be 6px as specified by 'b=6'. To increase the size give a higher value

The relevant code for the size is in pyWx/gui.py (line 645):
            self.dlg_library = imageFileBrowser.Dialog(
                parent=self,
                files=self.library_files_dictionary,
                title=_('Library Action Lists'),
                size=(self.GetSize()[0], 370),
                icon_size=(128, 128))
       (...)

-> You need to replace 370 with a higher value until two rows of thumbnails are visible. So what is this value?

Please attach a screenshot so I can evaluate the result.

Thanks!






References