phpdevshell team mailing list archive

[Smokey <smokey490@xxxxxxxxx>]

Hmm, well I think every framework out there fits some needs.. It mostly depends on the projects goal and the devs whishes.. I actually only started to look over this about 3 or 4 days ago... It just got my attention because it provides minimum needs without two much pressumtions or without forcing me to spend a month learning a new API just so I can write a bare minimum over an "hello world" program, and well, that's what I was looking for. Don't know if this was your intentions or not, but you got this right.. at least as far as I'm concerned
Ohh, as long as we're on the subject, I don't want to critisize but you guys should really write more documentation for it, since it is a great framework but without this few bugs that I found while testing to see if I could work with it, I really don't think I would have learned enough from docs.. Mostly browsing your code to see where things fit helped me learn much about your framework.. On the other hand, the good part is that your code is easy to browse and understand..

Regarding overriding, I've read about something like this somewhere on
your site.. or while bug browsing.. not sure.. Anyway, thanks for the
info.. Usefull in some places, but on problems like this I prefer to
edit directly.. There's simply no reason to overcomplicate it...

P.S. Everybody does modular nowdays... I think doing modular while
keeping things simple (and not just braging about it being simple) is
the trick.. And you've somehow managed to do this so far..

-- 
You received this bug notification because you are a member of
PHPDevShell, which is subscribed to PHPDevShell.
https://bugs.launchpad.net/bugs/1117723

Title:
  USER_getGroupsQuery and USER_getRolesQuery give back very wrong
  results in some cases

Status in Open Source PHP RAD Framework with UI.:
  Confirmed

Bug description:
  Both methods are written without really taking into account that they
  might be called to get informations about another user, not the logged
  in one.

  PHPDS->USER_getRolesQuery() checks $this->user->mergeRoles and
  abandons further database checks if that field is not empty. It also
  writes informations to $this->user->mergeRoles, so the results of the
  first user checked by this query will be the only result given back by
  it in future calls. And I'm pretty sure $this->user->mergeRoles should
  return only current users roles.

  PHPDS->USER_getGroupsQuery() does exactly the same with $this->user->mergeGroups, and further more it gives back the main group more than once (this is because $group_string will contain the main group after checking it for childs. $group_main shouln't be merged with $group_string after this).
  Also, $group_array is an array resonse from a query. It should be extended with $group_array[] = array('user_group_id' => $group_main), not $group_array[$group_main] = array('user_group_id' => $group_main)

  To test this just run $this->userGetRoles($userid) or
  $this->userGetGroups($userid) for 2 different users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/phpdevshell/+bug/1117723/+subscriptions