pkg-perl-maintainers team mailing list archive

[Christian Ehrhardt  <1951067@xxxxxxxxxxxxxxxxxx>]

Review for Package: libio-interactive-perl

[Summary]
MIR team ACK

This package is very small, well maintained, does not seem to need a lot of
attention. And with 4 autopkgtest and 16 build time tests for - after
subtracting the boilerplate - mabye 60 lines of code it is also well covered.
Imagine that ratio of 1 test per 3 LOC for every project.

This does not need a security review

List of specific binary packages to be promoted to main: libio-interactive-perl
Specific binary packages built, but NOT to be promoted to main: <none>

[Duplication]
There is no other package in main providing the same functionality.

[Dependencies]
OK:
- no other Dependencies to MIR due to this
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

Problems: None

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have odd Built-Using entries
- not a go package, no extra constraints to consider in that regard

Problems: None

[Security]
RULE: - Determine if the package may have security implications or history.
RULE:   Err on the side of caution.
RULE: - If the package is security sensitive, you should review as much as you
RULE:   can and then assign to the ubuntu-security team. The bug will then be
RULE:   added to the prioritized list of MIR security reviews.

OK:
- history of CVEs does not look concerning (none)
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats
- does not open a port/socket
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)

Problems: None

[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
  - test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
  TBH It is rather simple but matching the library and run via
  autopkgtest-pkg-perl
- no special HW required
- no new python2 dependency

Problems: None

[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- d/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is slow but ok (not much code)
- Debian/Ubuntu update history is slow but ok (not much code)
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
  maintained the package
- no massive Lintian warnings
- d/rules is rather clean (as clean as possible)
- It is not on the lto-disabled list

Problems: None

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (perl)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
  tests)
- no use of user nobody
- no use of setuid
- use of setuid, but ok because <TBD> (prefer systemd to set those
  for services)
- no important open bugs (crashers, etc) in Debian or Ubuntu (zero)
  There is one, issue for a special windows only condition and nothing else.
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks
- no translation present, but none needed for this case
  (not user visible)?

Problems: None

** Changed in: libio-interactive-perl (Ubuntu)
     Assignee: Christian Ehrhardt  (paelzer) => (unassigned)

** Changed in: libio-interactive-perl (Ubuntu)
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Debian
Perl Group, which is subscribed to libio-interactive-perl in Ubuntu.
https://bugs.launchpad.net/bugs/1951067

Title:
  [MIR] libio-interactive-perl

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libio-interactive-perl/+bug/1951067/+subscriptions