pkg-perl-maintainers team mailing list archive

[Didier Roche-Tolomelli <2003083@xxxxxxxxxxxxxxxxxx>]

Review for Package: libstring-license-perl

[Summary]
MIR team ACK under the constraint to resolve the below listed recommended TODOs.
This does not need a security review

Notes:
Recommended TODOs:
- Need clarification on what is the latest upstream release. Running uscan fetched a new version (0.0.4) which is not in upstream git repo: https://salsa.debian.org/perl-team/modules/packages/libstring-license-perl/-/tags. Debian is also on 0.0.2. Do you mind checking?

[Duplication]
There is no other package in main providing the same functionality.

[Dependencies]
OK:
- no other Dependencies to MIR due to this
- libstring-license-perl checked with `check-mir`
- all dependencies can be found in `seeded-in-ubuntu` (already in main)
- none of the (potentially auto-generated) dependencies (Depends
  and Recommends) that are present after build are not in main
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard

[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
  xml, json, asn.1], network packets, structures, ...) from
  an untrusted source. (Only from local package source code files)
- does not open a port/socket
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates, signing, ...)

[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- This does not need special HW for build or test
- no new python2 dependency

[Packaging red flags]
OK:
- Ubuntu does carry a delta, but it is reasonable and maintenance under
  control
- symbols tracking not applicable for this kind of code.
- d/watch is present and looks ok
- Upstream update history is good
- Debian/Ubuntu update history is good
- promoting this does not seem to cause issues for MOTUs that so far
- no massive Lintian warnings
- d/rules is rather clean
- It is not on the lto-disabled list

Problems:
- Need clarification on what is the latest upstream release. Running uscan fetched a new version (0.0.4) which is not in upstream git repo: https://salsa.debian.org/perl-team/modules/packages/libstring-license-perl/-/tags. Debian is also on 0.0.2. Do you mind checking?

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
  tests)
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks
- no translation present, but none needed for this case


** Changed in: libstring-license-perl (Ubuntu)
     Assignee: Didier Roche-Tolomelli (didrocks) => (unassigned)

** Changed in: libstring-license-perl (Ubuntu)
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of Debian
Perl Group, which is subscribed to licensecheck in Ubuntu.
https://bugs.launchpad.net/bugs/2003083

Title:
  [MIR] libstring-license-perl

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libstring-license-perl/+bug/2003083/+subscriptions