pkg-perl-maintainers team mailing list archive

[Didier Roche-Tolomelli <2024245@xxxxxxxxxxxxxxxxxx>]

Review for Package: libhttp-cookiejar-perl

[Summary]
Before giving the MIR ack, there is a pending question about the transition to this package to ensure we only have one perl cookie handler and don’t start having duplicated functionality from this perl lib.
Apart from that, the package needs a security review, so, once the opened question is solved, I'll assign ubuntu-security.
List of specific binary packages to be promoted to main: libhttp-cookiejar-perl

Notes:
- Required TODOs:
Question to resolve: It's mentioned that this "safer cookie jar" is supposed to replace libhttp-cookies-perl. However, as you have rightly written, libwww-mechanize-perl is still a reverse-dependency of libhttp-cookies-perl. Is there any bug/plan to track and transition a full migration to libhttp-cookiejar-perl so that we don’t have to maintain both in the long term? As this package is there for some years already, should we be concerned the transition might never happen?

Recommended TODOs:
- The package should get a team bug subscriber before being promoted.

[Duplication]
It's mentioned that this "safer cookie jar" is supposed to replace libhttp-cookies-perl. However, as you have rightly written, libwww-mechanize-perl is still a reverse-dependency of libhttp-cookies-perl. Is there any bug/plan to track and transition a full migration to libhttp-cookiejar-perl so that we don’t have to maintain both in the long term? As this package is there for some years already, should we be concerned the transition might never happen?

[Dependencies]
OK:
- no other Dependencies to MIR due to this
- libhttp-cookiejar-perl checked with `check-mir`
- all dependencies can be found in `seeded-in-ubuntu` (already in main)
- none of the (potentially auto-generated) dependencies (Depends
  and Recommends) that are present after build are not in main
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard

[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not open a port/socket
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates, signing, ...)

Problems:
- does process arbitrary web content and parse data formats from an untrusted source and store them on disk. Require a security review then.


[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- no new python2 dependency

[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- debian/watch is present and looks ok
- Upstream update history issporadic
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (the language has no direct MM)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks
- no translation present, but none needed for this case (user visible)?


** Changed in: libhttp-cookiejar-perl (Ubuntu)
       Status: New => Incomplete

** Changed in: libhttp-cookiejar-perl (Ubuntu)
     Assignee: Didier Roche-Tolomelli (didrocks) => (unassigned)

-- 
You received this bug notification because you are a member of Debian
Perl Group, which is subscribed to libhttp-cookiejar-perl in Ubuntu.
https://bugs.launchpad.net/bugs/2024245

Title:
  [MIR] libhttp-cookiejar-perl

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libhttp-cookiejar-perl/+bug/2024245/+subscriptions